content/browser/accessibility/accessibility_tree_formatter_blink.cc - Issue 2217363002: Use relative bounding boxes throughout Chrome accessibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/accessibility_tree_formatter_blink.cc

Issue 2217363002: Use relative bounding boxes throughout Chrome accessibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address feedback from aboxhall Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/extensions/automation_internal_custom_bindings.cc ('k') | content/browser/accessibility/browser_accessibility.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/accessibility_tree_formatter_blink.cc

diff --git a/content/browser/accessibility/accessibility_tree_formatter_blink.cc b/content/browser/accessibility/accessibility_tree_formatter_blink.cc

index 99c241bf5149a4bdaed9f943c060316a33be0d67..00d9a0693847085b85d48198cbd752c625420ad1 100644

--- a/content/browser/accessibility/accessibility_tree_formatter_blink.cc

+++ b/content/browser/accessibility/accessibility_tree_formatter_blink.cc

@@ -49,7 +49,7 @@ void AccessibilityTreeFormatterBlink::AddProperties(

dict->SetInteger("boundsWidth", bounds.width());

dict->SetInteger("boundsHeight", bounds.height());

- gfx::Rect page_bounds = node.GetLocalBoundsRect();

+ gfx::Rect page_bounds = node.GetPageBoundsRect();

dict->SetInteger("pageBoundsX", page_bounds.x());

dict->SetInteger("pageBoundsY", page_bounds.y());

dict->SetInteger("pageBoundsWidth", page_bounds.width());