content/test/data/accessibility/html/iframe-transform-cross-process-expected-blink.txt - Issue 2217363002: Use relative bounding boxes throughout Chrome accessibility

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/test/data/accessibility/html/iframe-transform-cross-process-expected-blink.txt

Issue 2217363002: Use relative bounding boxes throughout Chrome accessibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/accessibility/browser_accessibility_win.cc ('K') | « content/renderer/accessibility/render_accessibility_impl.cc ('k') | content/test/data/accessibility/html/iframe-transform-expected-blink.txt » ('j') | ui/accessibility/ax_node.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 rootWebArea pageLocation=(0, 0)	1 rootWebArea pageLocation=(0, 0)

2 ++iframe pageLocation=(0, 0)	2 ++iframe pageLocation=(0, 0)

3 ++++rootWebArea pageLocation=(0, 0)	3 ++++rootWebArea pageLocation=(0, 0)

4 ++++++image pageLocation=(10, 10) pageSize=(200, 200)	4 ++++++image pageLocation=(10, 10) pageSize=(200, 200)

5 ++iframe pageLocation=(0, 300)	5 ++iframe pageLocation=(0, 300) transform
	aboxhall 2016/08/12 16:05:10 Where does this ("transform") come from now? Where does this ("transform") come from now? dmazzoni 2016/08/15 05:31:11 The html for this test really does have it transfo Show quoted text On 2016/08/12 at 16:05:10, aboxhall wrote: > Where does this ("transform") come from now? The html for this test really does have it transformed - the first iframe is normal and the second iframe has style="transform: scale(2.0);" (plus some other things) on it. However, prior to this patch, when it was a cross process frame, that frame didn't actually know its own transformation! The only way we got it was by asking the frame tree in the browser process for the transformation matrix for that iframe, and it was never part of the AX tree. It worked, but it was really complicated to make it work. With this patch, it's so much simpler. The element that actually has the style="transform: scale(2.0);" attribute on it is the one that gets a transformation matrix in the AX tree, and all coordinates in that subtree get transformed automatically when converting to global coordinates. After this change lands I'll be able to get rid of all of that complicated code to do it the other way!
6 ++++rootWebArea pageLocation=(0, 300)	6 ++++rootWebArea pageLocation=(0, 300)

7 ++++++image pageLocation=(20, 320) pageSize=(400, 400)	7 ++++++image pageLocation=(20, 320) pageSize=(400, 400)

OLD	NEW