Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Issue 2217283002: Revert of Don't IAT patch SetUnhandledExceptionFilter when ASan is active (Closed)

Created:
4 years, 4 months ago by inferno
Modified:
4 years, 4 months ago
CC:
chromium-reviews, pennymac+watch_chromium.org, caitkp+watch_chromium.org, penny
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Don't IAT patch SetUnhandledExceptionFilter when ASan is active (patchset #1 id:1 of https://codereview.chromium.org/2220583002/ ) Reason for revert: Hangs instead of sad tabs for Win ASAN builds. See crashpad logs. [13236:14660:0805/105718:ERROR:crashpad_client_win.cc(484)] haven't called UseHandler() Original issue's description: > Don't IAT patch SetUnhandledExceptionFilter when ASan is active > > ASan installs its own exception filter that ClusterFuzz needs to see. > > R=robertshield@chromium.org,inferno@chromium.org > BUG=626373 > > Committed: https://crrev.com/3894e46c8c2702e12d2ddec12f186d7c1cf5c412 > Cr-Commit-Position: refs/heads/master@{#410077} TBR=robertshield@chromium.org,rnk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=626373

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M chrome_elf/chrome_elf_main.cc View 3 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
inferno
Created Revert of Don't IAT patch SetUnhandledExceptionFilter when ASan is active
4 years, 4 months ago (2016-08-05 18:01:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217283002/1
4 years, 4 months ago (2016-08-05 18:02:02 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 18:02:37 UTC) #7
Failed to apply the patch.

Powered by Google App Engine
This is Rietveld 408576698