Desaturate the favicon shown in the tab when a network error is encountered

chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc

Index: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
diff --git a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
index 0d00ebef770f6e86e76929d267ec50325d3e5155..4388b26f7c8128f341293f65b5372c3614f6cf8b 100644
--- a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
+++ b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
@@ -35,6 +35,9 @@
 #include "components/omnibox/browser/autocomplete_match.h"
 #include "components/prefs/pref_service.h"
 #include "content/public/browser/browser_thread.h"
+#include "content/public/browser/navigation_controller.h"
+#include "content/public/browser/navigation_entry.h"
+#include "content/public/browser/navigation_handle.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/plugin_service.h"
 #include "content/public/browser/user_metrics.h"
@@ -54,8 +57,15 @@ namespace {
 
 TabRendererData::NetworkState TabContentsNetworkState(
     WebContents* contents) {
-  if (!contents || !contents->IsLoadingToDifferentDocument())
+  if (!contents || !contents->IsLoadingToDifferentDocument()) {
+    if (contents) {

[sky, 2016/08/12 15:29:25]

This is mildly awkward because of the !contents 1 line above. How about slightly
restructuring to:

if (!contents)
  return NONE;

if (!contents->IsLoadingToDifferentDocument())
  ...

[edwardjung, 2016/08/12 19:29:25]

Done.

+      content::NavigationEntry* entry =
+          contents->GetController().GetLastCommittedEntry();
+      if (entry && (entry->GetPageType() == content::PAGE_TYPE_ERROR))
+        return TabRendererData::NETWORK_STATE_ERROR;
+    }
     return TabRendererData::NETWORK_STATE_NONE;
+  }
   if (contents->IsWaitingForResponse())
     return TabRendererData::NETWORK_STATE_WAITING;
   return TabRendererData::NETWORK_STATE_LOADING;