Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: fpdfsdk/javascript/color.h

Issue 2217253002: Remove backpointer to runtime from CJS_Array. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: fpdfsdk/javascript/color.h
diff --git a/fpdfsdk/javascript/color.h b/fpdfsdk/javascript/color.h
index 2beddb58fc79e9fd704b32042b595e3065f738ec..c3998bdbdcd3816af3701d871e8ccaeda7b37c05 100644
--- a/fpdfsdk/javascript/color.h
+++ b/fpdfsdk/javascript/color.h
@@ -42,8 +42,12 @@ class color : public CJS_EmbedObj {
CFX_WideString& sError);
public:
- static void ConvertPWLColorToArray(const CPWL_Color& color, CJS_Array& array);
- static void ConvertArrayToPWLColor(CJS_Array& array, CPWL_Color& color);
+ static void ConvertPWLColorToArray(CJS_Runtime* pRuntime,
+ const CPWL_Color& color,
+ CJS_Array& array);
Lei Zhang 2016/08/05 17:41:58 Change to a pointer?
Tom Sepez 2016/08/08 16:25:50 Yeah, both of these would benefit. Done. Also rem
+ static void ConvertArrayToPWLColor(CJS_Runtime* pRuntime,
+ CJS_Array& array,
+ CPWL_Color& color);
private:
CPWL_Color m_crTransparent;

Powered by Google App Engine
This is Rietveld 408576698