Remove backpointer to runtime from CJS_Array.

Remove backpointer to runtime from CJS_Array.

This is always available elsewhere, so save the bytes and ease
removal of CJS_Array since it now only contains a single v8 local.

Committed: https://pdfium.googlesource.com/pdfium/+/e5aff74a43a2c3355a8b7699a47d0fb7f23b243e

[Tom Sepez, 2016-08-05 17:11:17]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-05 17:11:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-08-05 17:19:16]

Description was changed from

==========
Remove backpointer to runtime from CJS_Array.

This is always available elsewhere, so save the bytes and ease
removal of CJS_Array since it now only contains a single v8 local.
==========

to

==========
Remove backpointer to runtime from CJS_Array.

This is always available elsewhere, so save the bytes and ease
removal of CJS_Array since it now only contains a single v8 local.
==========

[Tom Sepez, 2016-08-05 17:19:16]

tsepez@chromium.org changed reviewers:
+ jochen@chromium.org, thestig@chromium.org

[Tom Sepez, 2016-08-05 17:22:01]

Lei, for review.  This doesn't quite fall under jochen's bailiwick, but added
him anyhow.

[commit-bot: I haz the power, 2016-08-05 17:23:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-05 17:23:12]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-08-05 17:41:58]

lgtm

https://codereview.chromium.org/2217253002/diff/1/fpdfsdk/javascript/app.cpp
File fpdfsdk/javascript/app.cpp (right):

https://codereview.chromium.org/2217253002/diff/1/fpdfsdk/javascript/app.cpp#...
fpdfsdk/javascript/app.cpp:152: // CJS_Runtime* pRuntime =
pContext->GetJSRuntime();
Delete?

https://codereview.chromium.org/2217253002/diff/1/fpdfsdk/javascript/color.h
File fpdfsdk/javascript/color.h (right):

https://codereview.chromium.org/2217253002/diff/1/fpdfsdk/javascript/color.h#...
fpdfsdk/javascript/color.h:47: CJS_Array& array);
Change to a pointer?

[Tom Sepez, 2016-08-08 16:13:35]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-08 16:13:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 16:24:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-08 16:24:53]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-08-08 16:25:50]

https://codereview.chromium.org/2217253002/diff/1/fpdfsdk/javascript/app.cpp
File fpdfsdk/javascript/app.cpp (right):

https://codereview.chromium.org/2217253002/diff/1/fpdfsdk/javascript/app.cpp#...
fpdfsdk/javascript/app.cpp:152: // CJS_Runtime* pRuntime =
pContext->GetJSRuntime();
On 2016/08/05 17:41:58, Lei Zhang wrote:
> Delete?

Done.

https://codereview.chromium.org/2217253002/diff/1/fpdfsdk/javascript/color.h
File fpdfsdk/javascript/color.h (right):

https://codereview.chromium.org/2217253002/diff/1/fpdfsdk/javascript/color.h#...
fpdfsdk/javascript/color.h:47: CJS_Array& array);
On 2016/08/05 17:41:58, Lei Zhang wrote:
> Change to a pointer?

Yeah, both of these would benefit.  Done.
Also removed duplicate public: label.

[Tom Sepez, 2016-08-08 16:28:40]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-08-08 16:28:40]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2217253002/#ps40001
(title: "Remove non-const refs")

[commit-bot: I haz the power, 2016-08-08 16:28:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 16:49:49]

Description was changed from

==========
Remove backpointer to runtime from CJS_Array.

This is always available elsewhere, so save the bytes and ease
removal of CJS_Array since it now only contains a single v8 local.
==========

to

==========
Remove backpointer to runtime from CJS_Array.

This is always available elsewhere, so save the bytes and ease
removal of CJS_Array since it now only contains a single v8 local.

Committed:
https://pdfium.googlesource.com/pdfium/+/e5aff74a43a2c3355a8b7699a47d0fb7f23b...
==========

[commit-bot: I haz the power, 2016-08-08 16:49:50]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/e5aff74a43a2c3355a8b7699a47d0fb7f23b...