Issue 2217233002: Fix an ODR violation for ModalDialogDelegate found by ASan

Issue 2217233002: Fix an ODR violation for ModalDialogDelegate found by ASan (Closed)

Created:
4 years, 4 months ago by Reid Kleckner

Modified:
4 years, 4 months ago

Reviewers:
Nico

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix an ODR violation for ModalDialogDelegate found by ASan Move these classes into anonymous namespaces so the names of their vtables and virtual methods don't collide at link time. R=thakis@chromium.org BUG=634960 Committed: https://crrev.com/3716c0f10365f0f7c1dd225ebc95a5c6aff419f4 Cr-Commit-Position: refs/heads/master@{#410109}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download
	M	ui/views/widget/widget_unittest.cc	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 8 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217233002/1

4 years, 4 months ago (2016-08-05 17:21:21 UTC) #5

commit-bot: I haz the power

4 years, 4 months ago (2016-08-05 18:09:44 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3716c0f10365f0f7c1dd225ebc95a5c6aff419f4
Cr-Commit-Position: refs/heads/master@{#410109}