Issue 22172002: Return start/end profiling time in microseconds instead of milliseconds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22172002: Return start/end profiling time in microseconds instead of milliseconds (Closed)

Created:
7 years, 4 months ago by yurys

Modified:
7 years, 4 months ago

Reviewers:
Benedikt Meurer, alph, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Return start/end profiling time in microseconds instead of milliseconds The start and end time are now measured in microseconds and the type is int64_t. This way it seems more natural as we are going to support submilisecond sampling rate soon. Also it fixes cctest/test-cpu-profiler/ProfileStartEndTime test failure caused by comparison between long double and double. TEST=cctest/test-cpu-profiler/ProfileStartEndTime BUG=v8:2824 R=alph@chromium.org, bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16049

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -20 lines)			Patch
M	include/v8-profiler.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/profile-generator.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/profile-generator.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	test/cctest/test-cpu-profiler.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

yurys

This is a fix for cctest/test-cpu-profiler/ProfileStartEndTime failure on non-sse builds.

7 years, 4 months ago (2013-08-05 10:20:46 UTC) #1

yurys

Committed patchset #1 manually as r16049 (presubmit successful).

7 years, 4 months ago (2013-08-05 11:48:31 UTC) #4

Benedikt Meurer

7 years, 4 months ago (2013-08-05 12:33:09 UTC) #5

Message was sent while issue was closed.

On 2013/08/05 11:48:31, Yury Semikhatsky wrote:
> Committed patchset #1 manually as r16049 (presubmit successful).

Reverted due to windows build breakage.

Note that we're currently trying to stabilize the tree.

Expand Messages | Collapse Messages