Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2217193002: [Interpreter] Inline FastCloneRegExpStub to CreateRegExpLiteral bytecode handler. (Closed)

Created:
4 years, 4 months ago by rmcilroy
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Inline FastCloneRegExpStub to CreateRegExpLiteral bytecode handler. BUG=v8:4280 Committed: https://crrev.com/01e657d42fc926dd5cea9c58e1bbac96d84d54be Cr-Commit-Position: refs/heads/master@{#38422}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -14 lines) Patch
M src/code-stubs.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/code-stubs.cc View 2 chunks +30 lines, -10 lines 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
rmcilroy
Michi / Klaas, please take a look. Thanks.
4 years, 4 months ago (2016-08-05 16:50:22 UTC) #6
klaasb
lgtm
4 years, 4 months ago (2016-08-05 17:15:41 UTC) #7
Michael Starzinger
LGTM.
4 years, 4 months ago (2016-08-08 08:46:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217193002/1
4 years, 4 months ago (2016-08-08 08:51:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 09:15:30 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 09:19:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01e657d42fc926dd5cea9c58e1bbac96d84d54be
Cr-Commit-Position: refs/heads/master@{#38422}

Powered by Google App Engine
This is Rietveld 408576698