Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2217113003: Revert of Clang toolchain: use lld to compile LLVM Gold plugin and lld with LTO. (Closed)

Created:
4 years, 4 months ago by Nico
Modified:
4 years, 4 months ago
Reviewers:
hans, krasin1, pcc1, krasin
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, dmikurube+clang_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Clang toolchain: use lld to compile LLVM Gold plugin and lld with LTO. (patchset #10 id:180001 of https://codereview.chromium.org/2158753003/ ) Reason for revert: Somewhat speculative; it's possible this breaks building clang packages. See crbug.com/629966 comment 36 / 37. Original issue's description: > Clang toolchain: ship lld; build the whole toolchain with LTO. > > This only affects the Linux build. > > BUG=607968 > > Committed: https://crrev.com/36bb2be2523c83aa6b7601e92753dd49ae1924d3 > Cr-Commit-Position: refs/heads/master@{#407702} TBR=hans@chromium.org,pcc@chromium.org,krasin@chromium.org,krasin@google.com NOTRY=true BUG=607968 Committed: https://crrev.com/d858f427b0ed6d932975105f8dc9a072da99e3cb Cr-Commit-Position: refs/heads/master@{#410118}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -45 lines) Patch
M tools/clang/scripts/package.py View 2 chunks +1 line, -2 lines 0 comments Download
M tools/clang/scripts/update.py View 9 chunks +33 lines, -43 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Nico
Created Revert of Clang toolchain: use lld to compile LLVM Gold plugin and lld with ...
4 years, 4 months ago (2016-08-05 18:21:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217113003/1
4 years, 4 months ago (2016-08-05 18:22:10 UTC) #3
krasin
On 2016/08/05 18:21:35, Nico wrote: > Created Revert of Clang toolchain: use lld to compile ...
4 years, 4 months ago (2016-08-05 18:22:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217113003/1
4 years, 4 months ago (2016-08-05 18:26:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 18:29:55 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 18:32:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d858f427b0ed6d932975105f8dc9a072da99e3cb
Cr-Commit-Position: refs/heads/master@{#410118}

Powered by Google App Engine
This is Rietveld 408576698