Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2217073004: Re-enable CronetSampleTest#testLoadUrl (Closed)

Created:
4 years, 4 months ago by xunjieli
Modified:
4 years, 4 months ago
Reviewers:
mef
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable CronetSampleTest#testLoadUrl This CL re-enables CronetSampleTest#testLoadUrl to investigate the flaky test. BUG=635021 Committed: https://crrev.com/b9b46bf1618cecf78f569c2b1bdb00c9f607c3dc Cr-Commit-Position: refs/heads/master@{#411110}

Patch Set 1 #

Patch Set 2 : fix BUILD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M components/cronet/android/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/sample/javatests/src/org/chromium/cronet_sample_apk/CronetSampleTest.java View 4 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
xunjieli
4 years, 4 months ago (2016-08-05 21:49:11 UTC) #2
mef
lgtm
4 years, 4 months ago (2016-08-10 01:17:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217073004/20001
4 years, 4 months ago (2016-08-10 17:19:51 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-10 19:00:11 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 19:01:57 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b9b46bf1618cecf78f569c2b1bdb00c9f607c3dc
Cr-Commit-Position: refs/heads/master@{#411110}

Powered by Google App Engine
This is Rietveld 408576698