Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2217063003: Update cloud package. (Closed)

Created:
4 years, 4 months ago by dnj
Modified:
4 years, 4 months ago
Reviewers:
Vadim Sh., iannucci, nodir
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/gae@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Update cloud package. Fixes #54. BUG=None TEST=None Committed: https://github.com/luci/gae/commit/747577ae5a8c1be5d5497e3449b6b8a7c00f14ba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M impl/cloud/context.go View 1 chunk +1 line, -1 line 0 comments Download
M impl/cloud/datastore.go View 1 chunk +1 line, -1 line 0 comments Download
M impl/cloud/datastore_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dnj
PTAL. LUCI/gae was easy. Requires: https://codereview.chromium.org/2220533002
4 years, 4 months ago (2016-08-05 16:36:57 UTC) #2
Vadim Sh.
lgtm
4 years, 4 months ago (2016-08-05 18:34:54 UTC) #3
Vadim Sh.
Landing this one too. I want to get rid of old go/cloud package in deps.yaml.
4 years, 4 months ago (2016-08-05 21:07:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217063003/1
4 years, 4 months ago (2016-08-05 21:07:23 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 21:10:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/747577ae5a8c1be5d5497e3449b6b8a7c00f14ba

Powered by Google App Engine
This is Rietveld 408576698