Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2217013002: Remove the JNI-based InterfaceRegistry. (Closed)

Created:
4 years, 4 months ago by Sam McNally
Modified:
4 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, Peter Beverloo, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org, jochen+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@java-interface-registry-migration
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the JNI-based InterfaceRegistry. Java interface registration has been migrated to a Java-implemented InterfaceRegistry. This CL removes the now unused JNI-based InterfaceRegistry. BUG=634568, 637174, 649022 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/86ca7f13cfcf3a15a68133a270d04bec769aa2d1 Cr-Commit-Position: refs/heads/master@{#422013}

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1013 lines) Patch
M content/browser/BUILD.gn View 1 2 chunks +0 lines, -6 lines 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 2 chunks +0 lines, -6 lines 0 comments Download
D content/browser/android/interface_provider_android_impl.h View 1 chunk +0 lines, -43 lines 0 comments Download
D content/browser/android/interface_provider_android_impl.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D content/browser/android/interface_registry_android_impl.h View 1 chunk +0 lines, -48 lines 0 comments Download
D content/browser/android/interface_registry_android_impl.cc View 1 chunk +0 lines, -110 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 2 chunks +0 lines, -8 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 chunks +0 lines, -14 lines 0 comments Download
D content/browser/mojo/interface_registrar_android.h View 1 chunk +0 lines, -27 lines 0 comments Download
D content/browser/mojo/interface_registrar_android.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download
M content/public/android/BUILD.gn View 3 chunks +0 lines, -7 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/InterfaceProvider.java View 1 chunk +0 lines, -44 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/InterfaceRegistrar.java View 1 chunk +0 lines, -28 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/InterfaceRegistry.java View 1 chunk +0 lines, -77 lines 0 comments Download
D content/public/android/javatests/src/org/chromium/content/browser/InterfaceRegistryTest.java View 1 1 chunk +0 lines, -207 lines 0 comments Download
M content/public/browser/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
D content/public/browser/android/interface_provider_android.h View 1 chunk +0 lines, -43 lines 0 comments Download
D content/public/browser/android/interface_registry_android.h View 1 chunk +0 lines, -49 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/shell/android/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
D content/shell/android/java/src/org/chromium/content_shell/ShellMojoTestUtils.java View 1 chunk +0 lines, -53 lines 0 comments Download
M content/shell/android/shell_jni_registrar.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D content/shell/browser/shell_mojo_test_utils_android.h View 1 chunk +0 lines, -18 lines 0 comments Download
D content/shell/browser/shell_mojo_test_utils_android.cc View 1 chunk +0 lines, -99 lines 0 comments Download

Messages

Total messages: 40 (32 generated)
Sam McNally
4 years, 2 months ago (2016-09-28 08:54:56 UTC) #23
jam
lgtm please add to the cl description so that someone reading it can understand why ...
4 years, 2 months ago (2016-09-29 19:41:41 UTC) #24
Sam McNally
On 2016/09/29 19:41:41, jam wrote: > lgtm > > please add to the cl description ...
4 years, 2 months ago (2016-09-30 00:06:09 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217013002/120001
4 years, 2 months ago (2016-09-30 00:06:53 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/77722) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-09-30 00:10:25 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2217013002/140001
4 years, 2 months ago (2016-09-30 01:16:57 UTC) #36
commit-bot: I haz the power
Committed patchset #2 (id:140001)
4 years, 2 months ago (2016-09-30 02:00:47 UTC) #38
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 02:10:49 UTC) #40
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/86ca7f13cfcf3a15a68133a270d04bec769aa2d1
Cr-Commit-Position: refs/heads/master@{#422013}

Powered by Google App Engine
This is Rietveld 408576698