Issue 2217001: fixed test to use htpdate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2217001: fixed test to use htpdate (Closed)

Created:
10 years, 7 months ago by puneetster

Modified:
9 years, 7 months ago

Reviewers:
kdlucas

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/autotest.git

Visibility:
Public.

Description

fixed test to use htpdate TEST="run_remote_tests.sh ..."

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixed line widht < 80 characters #

Patch Set 3 : fixed for htpdate transition #

Patch Set 4 : added missing edits back #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -9 lines)			Patch
	M	client/site_tests/platform_AccurateTime/platform_AccurateTime.py	View	1 2 3	2 chunks	+10 lines, -8 lines	0 comments	Download
	M	client/site_tests/platform_DaemonsRespawn/test_respawn.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kdlucas

10 years, 7 months ago (2010-05-25 22:49:21 UTC) #2

LGTM after you fix the one line that exceeds 80 chars.

http://codereview.chromium.org/2217001/diff/1/2
File client/site_tests/platform_AccurateTime/platform_AccurateTime.py (right):

http://codereview.chromium.org/2217001/diff/1/2#newcode36
client/site_tests/platform_AccurateTime/platform_AccurateTime.py:36:
retain_output=True)
Looks like this line exceed 80 chars. You'll need to break this string up into
two lines.

Expand Messages | Collapse Messages