Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 221693004: Unit test both MQ parsers. Fix MQ parser block handling bugs (Closed)

Created:
6 years, 8 months ago by Yoav Weiss
Modified:
6 years, 8 months ago
Reviewers:
eseidel
CC:
blink-reviews, kenneth.christiansen, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Unit test both MQ parsers. Fix MQ parser block handling bugs Enables the MQ parser unit test to verify that both the Bison parser and MediaQueryParser are functioning as they should be. Also fixes a couple of bugs that were found in the process, and adds testing for these cases. BUG=358041, 358967 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170682

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fixed a couple of errors related to block handling. Added tests #

Total comments: 1

Patch Set 4 : Fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -116 lines) Patch
M Source/core/css/MediaQuerySetTest.cpp View 1 2 1 chunk +124 lines, -112 lines 0 comments Download
M Source/core/css/parser/MediaQueryParser.cpp View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Yoav Weiss
Followup on https://codereview.chromium.org/221383003/
6 years, 8 months ago (2014-04-02 05:01:51 UTC) #1
eseidel
lgtm Fantatsic. Please relate to a bug. :)
6 years, 8 months ago (2014-04-02 05:08:36 UTC) #2
Yoav Weiss
On 2014/04/02 05:08:36, eseidel wrote: > lgtm > > Fantatsic. Please relate to a bug. ...
6 years, 8 months ago (2014-04-02 10:02:29 UTC) #3
rune
https://codereview.chromium.org/221693004/diff/40001/Source/core/css/parser/MediaQueryParser.cpp File Source/core/css/parser/MediaQueryParser.cpp (right): https://codereview.chromium.org/221693004/diff/40001/Source/core/css/parser/MediaQueryParser.cpp#newcode182 Source/core/css/parser/MediaQueryParser.cpp:182: const unsigned blockParametersNumber = 4; We normally use enums ...
6 years, 8 months ago (2014-04-02 12:48:30 UTC) #4
eseidel
Other than the capitalization nit from rune, lgtm.
6 years, 8 months ago (2014-04-02 17:18:37 UTC) #5
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 8 months ago (2014-04-02 17:26:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/221693004/60001
6 years, 8 months ago (2014-04-02 17:27:03 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 17:37:55 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-02 17:37:55 UTC) #9
Yoav Weiss
The CQ bit was checked by yoav@yoav.ws
6 years, 8 months ago (2014-04-02 17:59:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/221693004/60001
6 years, 8 months ago (2014-04-02 17:59:44 UTC) #11
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 19:07:29 UTC) #12
Message was sent while issue was closed.
Change committed as 170682

Powered by Google App Engine
This is Rietveld 408576698