PNaCl: Add support for GCC/LLVM vector extensions

lib/Transforms/NaCl/GlobalizeConstantVectors.cpp

Index: lib/Transforms/NaCl/GlobalizeConstantVectors.cpp
diff --git a/lib/Transforms/NaCl/GlobalizeConstantVectors.cpp b/lib/Transforms/NaCl/GlobalizeConstantVectors.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..2802f8016dded722730df69a18aab2849c694cbb
--- /dev/null
+++ b/lib/Transforms/NaCl/GlobalizeConstantVectors.cpp
@@ -0,0 +1,126 @@
+//===- GlobalizeConstantVectors.cpp - Globalize constant vector -----------===//
+//
+//                     The LLVM Compiler Infrastructure
+//
+// This file is distributed under the University of Illinois Open Source
+// License. See LICENSE.TXT for details.
+//
+//===----------------------------------------------------------------------===//
+//
+// This pass replaces all constant vector operands by loads of the same
+// vector value from a constant global. After this pass functions don't
+// rely on ConstantVector and ConstantDataVector.
+//
+//===----------------------------------------------------------------------===//
+
+#include "llvm/IR/Constants.h"
+#include "llvm/IR/DataLayout.h"
+#include "llvm/IR/Instructions.h"
+#include "llvm/IR/Module.h"
+#include "llvm/Pass.h"
+#include "llvm/Support/InstIterator.h"
+#include "llvm/Transforms/NaCl.h"
+
+using namespace llvm;
+
+namespace {
+// Must be a ModulePass since it adds globals.
+class GlobalizeConstantVectors : public ModulePass {
+public:
+  static char ID; // Pass identification, replacement for typeid
+  GlobalizeConstantVectors() : ModulePass(ID), TD(0) {
+    initializeGlobalizeConstantVectorsPass(*PassRegistry::getPassRegistry());
+  }
+  virtual void getAnalysisUsage(AnalysisUsage &AU) const {
+    AU.setPreservesCFG();
+    AU.addRequired<DataLayout>();
+  }
+  virtual bool runOnModule(Module &M);
+
+private:
+  typedef SmallVector<Value *, 128> Values;
+  const DataLayout *TD;
+
+  void findConstantVectors(const Function &F, Values &CVs) const;
+  void globalizeConstantVectors(Module &M, Function &F,
+                                const Values &CVs) const;
+};
+}
+
+char GlobalizeConstantVectors::ID = 0;
+INITIALIZE_PASS(GlobalizeConstantVectors, "globalize-constant-vectors",
+                "Replace constant vector operands with equivalent loads", false,
+                false)
+
+void GlobalizeConstantVectors::findConstantVectors(const Function &F,
+                                                   Values &CVs) const {
+  for (const_inst_iterator II = inst_begin(F), IE = inst_end(F); II != IE;
+       ++II) {
+    for (User::const_op_iterator OI = II->op_begin(), OE = II->op_end();
+         OI != OE; ++OI) {
+      Value *V = OI->get();
+      if (isa<ConstantVector>(V) || isa<ConstantDataVector>(V))
+        CVs.push_back(V);
+    }
+  }
+}
+
+void
+GlobalizeConstantVectors::globalizeConstantVectors(Module &M, Function &F,
+                                                   const Values &CVs) const {
+  // The first instruction in a function dominates all others, it is
+  // therefore a safe insertion point.
+  // TODO(jfb) Sink values closer to their use?
+  Instruction *FirstInst = F.getEntryBlock().getFirstNonPHI();
+  for (Values::const_iterator VI = CVs.begin(), VE = CVs.end(); VI != VE;
+       ++VI) {
+    Value *V = *VI;
+    static const char Name[] = "constant_vector";
+
+    GlobalVariable *GV = new GlobalVariable(
+        M, V->getType(), /* isConstant= */ true, GlobalValue::InternalLinkage,
+        cast<Constant>(V), Name);
+    GV->setAlignment(TD->getPrefTypeAlignment(V->getType()));
+    LoadInst *MaterializedGV = new LoadInst(GV, Name, /* isVolatile= */ false,
+                                            GV->getAlignment(), FirstInst);
+
+    for (Value::use_iterator UI = V->use_begin(), UE = V->use_end(); UI != UE;
+         ++UI) {
+      User *U = *UI;
+      Instruction *I = dyn_cast<Instruction>(U);

[Jim Stichnoth, 2014/04/04 23:08:17]

Another dyn_cast suggestion:

   if (Instruction *I = dyn_cast<Instruction>(U)) {
     if (I->getParent()->getParent() != &F)
       continue;
   }

[JF, 2014/04/15 01:52:27]

Done.

+      if (I && I->getParent()->getParent() != &F)
+        // Skip uses of the constant vector in other functions: we need
+        // to materialize it in every function which has a use.
+        continue;
+      if (isa<GlobalVariable>(U))
+        // Don't replace global uses of the constant vector: we just
+        // created a new one. This avoid recursive references.
+        continue;
+      for (User::op_iterator OI = U->op_begin(), OE = U->op_end(); OI != OE;
+           ++OI)
+        if (dyn_cast<Value>(*OI) == V)
+          // The current operand is a use of the constant vector,
+          // replace it with the materialized one.
+          *OI = MaterializedGV;
+    }
+  }
+}
+
+bool GlobalizeConstantVectors::runOnModule(Module &M) {
+  bool Changed = false;
+  TD = &getAnalysis<DataLayout>();
+  for (Module::iterator FI = M.begin(), FE = M.end(); FI != FE; ++FI) {
+    Function &F = *FI;
+    Values ConstantVectors;
+    findConstantVectors(F, ConstantVectors);
+    if (!ConstantVectors.empty()) {
+      Changed = true;
+      globalizeConstantVectors(M, F, ConstantVectors);
+    }
+  }
+  return Changed;
+}
+
+ModulePass *llvm::createGlobalizeConstantVectorsPass() {
+  return new GlobalizeConstantVectors();
+}