lib/Transforms/NaCl/FlattenGlobals.cpp - Issue 221693002: PNaCl: Add support for GCC/LLVM vector extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/Transforms/NaCl/FlattenGlobals.cpp

Issue 221693002: PNaCl: Add support for GCC/LLVM vector extensions (Closed) Base URL: http://git.chromium.org/native_client/pnacl-llvm.git@master

Patch Set: Address dschuff's comments. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/Transforms/NaCl/FlattenGlobals.cpp

diff --git a/lib/Transforms/NaCl/FlattenGlobals.cpp b/lib/Transforms/NaCl/FlattenGlobals.cpp

index a816875b347648863e8a1e544bcd8d7f8df88afa..6f9ceb35961d760be9676bf7641ecf902bd9ec61 100644

--- a/lib/Transforms/NaCl/FlattenGlobals.cpp

+++ b/lib/Transforms/NaCl/FlattenGlobals.cpp

@@ -178,7 +178,8 @@ void FlattenedConstant::putAtDest(DataLayout *DL, Constant *Val,

StringRef Data = CD->getRawDataValues();

assert(Data.size() == ValSize);

memcpy(Dest, Data.data(), Data.size());

- } else if (isa<ConstantArray>(Val) || isa<ConstantVector>(Val)) {

+ } else if (isa<ConstantArray>(Val) || isa<ConstantDataVector>(Val) ||

+ isa<ConstantVector>(Val)) {

jvoung (off chromium) 2014/04/16 00:10:27 Can you also add to the flatten-globals.ll test fo

uint64_t ElementSize = DL->getTypeAllocSize(

Val->getType()->getSequentialElementType());

for (unsigned I = 0; I < Val->getNumOperands(); ++I) {