Adjust scheduling of extension autoupdate checks

Adjust scheduling of extension autoupdate checks

As described in more detail in the associated bug, our current strategy
doesn't work all that great for users who don't leave chrome open for
long periods of time. This CL tries to address that by changing the
function which determines when to run the first update check after
startup. In the case where our last scheduled check time has passed,
instead of waiting a random time from a few minutes up to several hours
(with some bias towards shorter values the longer it's been since a
successful check), we instead only wait 1-5 minutes.

BUG=630450
Committed: https://crrev.com/15bb0b285183bbf4960573965b18d1e37b41d6f9
Cr-Commit-Position: refs/heads/master@{#410011}

[asargent_no_longer_on_chrome, 2016-08-04 22:38:48]

The CQ bit was checked by asargent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 22:39:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[asargent_no_longer_on_chrome, 2016-08-04 23:30:27]

asargent@chromium.org changed reviewers:
+ lazyboy@chromium.org

[lazyboy, 2016-08-05 00:04:19]

lgtm

https://codereview.chromium.org/2216893002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/updater/extension_updater.cc (right):

https://codereview.chromium.org/2216893002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/updater/extension_updater.cc:53: // Wait at least 30
seconds after browser startup before we do any checks. If
As discussed offline, I'd be comfortable if this value was at least 60 seconds,
30s feels a bit aggressive.
So I'd suggest something between 60s to 5mins.

https://codereview.chromium.org/2216893002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/updater/extension_updater.cc:189: saved_next < now +
TimeDelta::FromSeconds(frequency_seconds_))
nit: this requires {}

[asargent_no_longer_on_chrome, 2016-08-05 06:22:50]

Description was changed from

==========
Adjust scheduling of extension autoupdate checks

As described in more detail in the associated bug, our current strategy
doesn't work all that great for users who don't leave chrome open for
long periods of time. This CL tries to address that by changing the
function which determines when to run the first update check after
startup. In the case where our last scheduled check time has passed,
instead of waiting a random time from a few minutes up to several hours
(with some bias towards shorter values the longer it's been since a
successful check), we instead only wait 30-60 seconds.

BUG=630450
==========

to

==========
Adjust scheduling of extension autoupdate checks

As described in more detail in the associated bug, our current strategy
doesn't work all that great for users who don't leave chrome open for
long periods of time. This CL tries to address that by changing the
function which determines when to run the first update check after
startup. In the case where our last scheduled check time has passed,
instead of waiting a random time from a few minutes up to several hours
(with some bias towards shorter values the longer it's been since a
successful check), we instead only wait 1-5 minutes.

BUG=630450
==========

[asargent_no_longer_on_chrome, 2016-08-05 06:23:32]

https://codereview.chromium.org/2216893002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/updater/extension_updater.cc (right):

https://codereview.chromium.org/2216893002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/updater/extension_updater.cc:53: // Wait at least 30
seconds after browser startup before we do any checks. If
On 2016/08/05 00:04:19, lazyboy wrote:
> As discussed offline, I'd be comfortable if this value was at least 60
seconds,
> 30s feels a bit aggressive.
> So I'd suggest something between 60s to 5mins.

Done.

https://codereview.chromium.org/2216893002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/updater/extension_updater.cc:189: saved_next < now +
TimeDelta::FromSeconds(frequency_seconds_))
On 2016/08/05 00:04:19, lazyboy wrote:
> nit: this requires {}

Done.

[asargent_no_longer_on_chrome, 2016-08-05 06:23:39]

The CQ bit was checked by asargent@chromium.org

[asargent_no_longer_on_chrome, 2016-08-05 06:23:39]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/2216893002/#ps40001
(title: "address review feedback")

[commit-bot: I haz the power, 2016-08-05 06:23:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 07:16:53]

Description was changed from

==========
Adjust scheduling of extension autoupdate checks

As described in more detail in the associated bug, our current strategy
doesn't work all that great for users who don't leave chrome open for
long periods of time. This CL tries to address that by changing the
function which determines when to run the first update check after
startup. In the case where our last scheduled check time has passed,
instead of waiting a random time from a few minutes up to several hours
(with some bias towards shorter values the longer it's been since a
successful check), we instead only wait 1-5 minutes.

BUG=630450
==========

to

==========
Adjust scheduling of extension autoupdate checks

As described in more detail in the associated bug, our current strategy
doesn't work all that great for users who don't leave chrome open for
long periods of time. This CL tries to address that by changing the
function which determines when to run the first update check after
startup. In the case where our last scheduled check time has passed,
instead of waiting a random time from a few minutes up to several hours
(with some bias towards shorter values the longer it's been since a
successful check), we instead only wait 1-5 minutes.

BUG=630450
==========

[commit-bot: I haz the power, 2016-08-05 07:16:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-05 07:18:43]

Description was changed from

==========
Adjust scheduling of extension autoupdate checks

As described in more detail in the associated bug, our current strategy
doesn't work all that great for users who don't leave chrome open for
long periods of time. This CL tries to address that by changing the
function which determines when to run the first update check after
startup. In the case where our last scheduled check time has passed,
instead of waiting a random time from a few minutes up to several hours
(with some bias towards shorter values the longer it's been since a
successful check), we instead only wait 1-5 minutes.

BUG=630450
==========

to

==========
Adjust scheduling of extension autoupdate checks

As described in more detail in the associated bug, our current strategy
doesn't work all that great for users who don't leave chrome open for
long periods of time. This CL tries to address that by changing the
function which determines when to run the first update check after
startup. In the case where our last scheduled check time has passed,
instead of waiting a random time from a few minutes up to several hours
(with some bias towards shorter values the longer it's been since a
successful check), we instead only wait 1-5 minutes.

BUG=630450

Committed: https://crrev.com/15bb0b285183bbf4960573965b18d1e37b41d6f9
Cr-Commit-Position: refs/heads/master@{#410011}
==========

[commit-bot: I haz the power, 2016-08-05 07:18:44]

Patchset 3 (id:??) landed as
https://crrev.com/15bb0b285183bbf4960573965b18d1e37b41d6f9
Cr-Commit-Position: refs/heads/master@{#410011}