Add an "api signature" to summaries.

Add an "api signature" to summaries.

The API signature of a summary is an MD5 hash of the API of the code
being summarized.  This will be used by analysis server to detect when
a summary needs to be relinked (because it was built with reference to
another summary whose API has since changed).

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/70bd623f36f4037db778ba4e8cb9d279ad9687d0

[Paul Berry, 2016-08-04 22:29:59]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[scheglov, 2016-08-04 22:50:09]

LGTM

https://codereview.chromium.org/2216873003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/flat_buffers.dart (right):

https://codereview.chromium.org/2216873003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/flat_buffers.dart:28: class ApiSignature {
Until now this file was pretty much independent of summaries and was just a
general purpose flat-buffers implementation for Dart. Could we move this class
out of this file?

https://codereview.chromium.org/2216873003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/flat_buffers.dart:93: * Collect a 32-bit unsidneg
integer value.
unsigned

[Paul Berry, 2016-08-04 23:05:46]

https://codereview.chromium.org/2216873003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/flat_buffers.dart (right):

https://codereview.chromium.org/2216873003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/flat_buffers.dart:28: class ApiSignature {
On 2016/08/04 22:50:08, scheglov wrote:
> Until now this file was pretty much independent of summaries and was just a
> general purpose flat-buffers implementation for Dart. Could we move this class
> out of this file?

Done.

https://codereview.chromium.org/2216873003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/flat_buffers.dart:93: * Collect a 32-bit unsidneg
integer value.
On 2016/08/04 22:50:08, scheglov wrote:
> unsigned

Wow, that's a pretty bad transposition even by my standards!  Fixed.

[Paul Berry, 2016-08-04 23:12:54]

Description was changed from

==========
Add an "api signature" to summaries.

The API signature of a summary is an MD5 hash of the API of the code
being summarized.  This will be used by analysis server to detect when
a summary needs to be relinked (because it was built with reference to
another summary whose API has since changed).
==========

to

==========
Add an "api signature" to summaries.

The API signature of a summary is an MD5 hash of the API of the code
being summarized.  This will be used by analysis server to detect when
a summary needs to be relinked (because it was built with reference to
another summary whose API has since changed).

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/70bd623f36f4037db778ba4e8cb9d279ad9687d0
==========

[Paul Berry, 2016-08-04 23:12:55]

Committed patchset #1 (id:1) manually as
70bd623f36f4037db778ba4e8cb9d279ad9687d0 (presubmit successful).