Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Issue 2216733002: blink: honor renderer caret_blink_interval in non-default themes (Closed)

Created:
4 years, 4 months ago by Elly Fong-Jones
Modified:
4 years, 4 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dglazkov+blink, Dirk Pranke, eae+blinkwatch, jam, jchaffraix+rendering, kinuko+watch, leviw+renderwatch, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blink: honor renderer caret_blink_interval in non-default themes This occasioned moving WebRenderTheme out of default-theme-only blink builds, and moving the caret blink interval up from LayoutThemeDefault to LayoutTheme. BUG=500168 Committed: https://crrev.com/8ae17699e778e812a808d40b618874fbe2263f35 Cr-Commit-Position: refs/heads/master@{#410062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -126 lines) Patch
M content/renderer/render_view_impl.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTheme.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeDefault.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeDefault.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
A + third_party/WebKit/Source/web/WebRenderTheme.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
D third_party/WebKit/Source/web/default/WebRenderTheme.cpp View 1 chunk +0 lines, -52 lines 0 comments Download
M third_party/WebKit/Source/web/web.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/public/blink_headers.gypi View 2 chunks +1 line, -1 line 0 comments Download
A + third_party/WebKit/public/web/WebRenderTheme.h View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/public/web/default/WebRenderTheme.h View 1 chunk +0 lines, -46 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Elly Fong-Jones
esprehn: ptal? this is the first part of fixing 500168; the other part is to ...
4 years, 4 months ago (2016-08-04 18:47:12 UTC) #3
esprehn
Neat! You even got my TODO. :) lgtm
4 years, 4 months ago (2016-08-04 18:50:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216733002/1
4 years, 4 months ago (2016-08-04 19:22:27 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/204397)
4 years, 4 months ago (2016-08-04 21:11:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216733002/1
4 years, 4 months ago (2016-08-05 14:37:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 15:19:44 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 15:21:21 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ae17699e778e812a808d40b618874fbe2263f35
Cr-Commit-Position: refs/heads/master@{#410062}

Powered by Google App Engine
This is Rietveld 408576698