LayoutTests/fast/frames/javascript-url-style-crash.html - Issue 221673003: Defer iframe JavaScript URL evaluation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/frames/javascript-url-style-crash.html

Issue 221673003: Defer iframe JavaScript URL evaluation (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Removed redundant check Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <body>

	3 <script>

	4 function callback() {

	5 style0.innerHTML = '';

	6 iframe0.removeChild(style0);

	7 }

	8

	9 style0=document.createElement('style');

	10 style0.innerHTML = 'span { color: blue; }';

	11

	12 iframe0=document.createElement('iframe');

	13 iframe0.appendChild(style0);

	14 iframe0.src='javascript:window.top.callback();';

	15 document.body.appendChild(iframe0);

	16

	17 if (window.testRunner) {

	18 testRunner.waitUntilDone();

	19 testRunner.dumpAsText();

	20 setTimeout(function() {

	21 testRunner.notifyDone();

	22 }, 0);
	esprehn 2014/04/02 19:45:10 What are you trying to do with the setTimeout? Wai What are you trying to do with the setTimeout? Wait for a layout? setTimeout is flaky, you can't guarantee anything will happen. Do you want document.body.offsetTop to cause a layout? gmorrita 2014/04/02 19:47:30 Oops. This part just survived from my first change Show quoted text On 2014/04/02 19:45:10, esprehn wrote: > What are you trying to do with the setTimeout? Wait for a layout? > > setTimeout is flaky, you can't guarantee anything will happen. > > Do you want document.body.offsetTop to cause a layout? Oops. This part just survived from my first change where I tried to turn javascript: evaluation async. Will remove setTimeout().
	23 }

	24 </script>

	25 <p>PASS unless crash</p>

	26 </body>

OLD	NEW