LayoutTests/fast/frames/adopt-from-created-document.html - Issue 221673003: Defer iframe JavaScript URL evaluation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/frames/adopt-from-created-document.html

Issue 221673003: Defer iframe JavaScript URL evaluation (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <body>	1 <body>

2 <script>	2 <script>

3 if (window.testRunner)	3 if (window.testRunner)

4 testRunner.dumpAsText();	4 testRunner.dumpAsText();

5	5

6 alert(1);	6 alert(1);

7 var doc = document.implementation.createDocument('http://www.w3.org/1999/xhtml', 'html', null);	7 var doc = document.implementation.createDocument('http://www.w3.org/1999/xhtml', 'html', null);

8 alert(2);	8 alert(2);

9 var ifr = doc.createElement('iframe');	9 var ifr = doc.createElement('iframe');

10 alert(3);	10 alert(3);

11 ifr.setAttribute('src', 'javascript:alert(6)');	11 ifr.setAttribute('src', 'javascript:alert(7)');

12 alert(4);	12 alert(4);

13 var adopted = document.adoptNode(ifr)	13 var adopted = document.adoptNode(ifr)

14 alert(5);	14 alert(5);

15 document.body.appendChild(adopted);	15 document.body.appendChild(adopted);

16 alert(7);	16 alert(6);

17 </script>	17 </script>
	abarth-chromium 2014/04/02 00:54:57 I'm worried that we're going to break web sites wi I'm worried that we're going to break web sites with this change. Previously the JavaScript URL executed before appendChild returned. It looks like you've changed it to execute at the end of the script...
OLD	NEW