chrome/browser/ui/tab_helpers.cc - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Replace in .mm files Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tab_helpers.cc

diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc

index d46da69da6bf4dc5b7f77b28f4dd85c0f470490a..3aad1e61448c6e00cc53f43d0335595772ce7839 100644

--- a/chrome/browser/ui/tab_helpers.cc

+++ b/chrome/browser/ui/tab_helpers.cc

@@ -188,9 +188,8 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

#if BUILDFLAG(ANDROID_JAVA_UI)

banners::AppBannerManagerAndroid::CreateForWebContents(web_contents);

BookmarkLastVisitUpdater::CreateForWebContentsWithBookmarkModel(

- web_contents,

- BookmarkModelFactory::GetForProfile(

- Profile::FromBrowserContext(web_contents->GetBrowserContext())));

+ web_contents, BookmarkModelFactory::GetForBrowserContext(

+ web_contents->GetBrowserContext()));

ContextMenuHelper::CreateForWebContents(web_contents);

DataUseTabHelper::CreateForWebContents(web_contents);