chrome/browser/ui/webui/browsing_history_handler.cc - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/browsing_history_handler.cc

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Eliminate Profile::FromBrowserContext in some places Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/history/android/android_history_provider_service_unittest.cc ('K') | « chrome/browser/ui/views/toolbar/toolbar_view_browsertest.cc ('k') | chrome/browser/ui/webui/omnibox/omnibox_page_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/browsing_history_handler.cc

diff --git a/chrome/browser/ui/webui/browsing_history_handler.cc b/chrome/browser/ui/webui/browsing_history_handler.cc

index 74308017f5642ba08dcc5dfa4684cda1f3472e13..1d077ead9c228c00a3ec5eaa01a89b235f77d805 100644

--- a/chrome/browser/ui/webui/browsing_history_handler.cc

+++ b/chrome/browser/ui/webui/browsing_history_handler.cc

@@ -619,7 +619,7 @@ void BrowsingHistoryHandler::HandleClearBrowsingData(

void BrowsingHistoryHandler::HandleRemoveBookmark(const base::ListValue* args) {

base::string16 url = ExtractStringValue(args);

Profile* profile = Profile::FromWebUI(web_ui());

- BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile);

+ BookmarkModel* model = BookmarkModelFactory::GetForBrowserContext(profile);

bookmarks::RemoveAllBookmarks(model, GURL(url));

}

@@ -671,7 +671,8 @@ void BrowsingHistoryHandler::MergeDuplicateResults(

void BrowsingHistoryHandler::ReturnResultsToFrontEnd() {

Profile* profile = Profile::FromWebUI(web_ui());

- BookmarkModel* bookmark_model = BookmarkModelFactory::GetForProfile(profile);

+ BookmarkModel* bookmark_model =

+ BookmarkModelFactory::GetForBrowserContext(profile);

SupervisedUserService* supervised_user_service = NULL;

#if defined(ENABLE_SUPERVISED_USERS)

if (profile->IsSupervised())