chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Eliminate Profile::FromBrowserContext in some places Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/history/android/android_history_provider_service_unittest.cc ('K') | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm ('k') | chrome/browser/ui/cocoa/bookmarks/bookmark_menu_bridge.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm

index 1c346700f1bba6a9fbce214dac67eeb333e74a9b..a510d2b39482772163db9c29651da7e599b08736 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_button_unittest.mm

@@ -91,7 +91,7 @@ TEST_F(BookmarkButtonTest, FolderAndEmptyOrNot) {

// Since this returns (does not actually begin a modal drag), success!

[button beginDrag:downEvent];

- BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());

+ BookmarkModel* model = BookmarkModelFactory::GetForBrowserContext(profile());

const BookmarkNode* node = model->bookmark_bar_node();

[cell setBookmarkNode:node];

EXPECT_FALSE([button isEmpty]);

@@ -144,7 +144,7 @@ TEST_F(BookmarkButtonTest, DragToTrash) {

[button setDelegate:delegate];

// Add a deletable bookmark to the button.

- BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());

+ BookmarkModel* model = BookmarkModelFactory::GetForBrowserContext(profile());

const BookmarkNode* barNode = model->bookmark_bar_node();

const BookmarkNode* node = model->AddURL(barNode, 0,

base::ASCIIToUTF16("hi mom"),