chrome/browser/storage/durable_storage_browsertest.cc - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/storage/durable_storage_browsertest.cc

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Eliminate Profile::FromBrowserContext in some places Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/history/android/android_history_provider_service_unittest.cc ('K') | « chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc ('k') | chrome/browser/storage/durable_storage_permission_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/storage/durable_storage_browsertest.cc

diff --git a/chrome/browser/storage/durable_storage_browsertest.cc b/chrome/browser/storage/durable_storage_browsertest.cc

index 4327cd3fdc3648bfc9b6b07e7a7e9c70149593e0..1719f42a2e549aac3967b907bb80666e8e5e1736 100644

--- a/chrome/browser/storage/durable_storage_browsertest.cc

+++ b/chrome/browser/storage/durable_storage_browsertest.cc

@@ -43,7 +43,7 @@ class DurableStorageBrowserTest : public InProcessBrowserTest {

void Bookmark(Browser* browser) {

bookmarks::BookmarkModel* bookmark_model =

- BookmarkModelFactory::GetForProfile(browser->profile());

+ BookmarkModelFactory::GetForBrowserContext(browser->profile());

bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model);

bookmarks::AddIfNotBookmarked(bookmark_model, url_, base::ASCIIToUTF16(""));

}

@@ -120,7 +120,7 @@ IN_PROC_BROWSER_TEST_F(DurableStorageBrowserTest, BookmarkThenUnbookmark) {

EXPECT_TRUE(is_persistent);

bookmarks::BookmarkModel* bookmark_model =

- BookmarkModelFactory::GetForProfile(browser()->profile());

+ BookmarkModelFactory::GetForBrowserContext(browser()->profile());

bookmarks::RemoveAllBookmarks(bookmark_model, url_);

// Unbookmarking doesn't change the permission.