chrome/browser/profiles/profile_manager_unittest.cc - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_manager_unittest.cc

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Eliminate Profile::FromBrowserContext in some places Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/history/android/android_history_provider_service_unittest.cc ('K') | « chrome/browser/profiles/profile_impl.cc ('k') | chrome/browser/profiles/profile_statistics_aggregator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_manager_unittest.cc

diff --git a/chrome/browser/profiles/profile_manager_unittest.cc b/chrome/browser/profiles/profile_manager_unittest.cc

index b3423f451037adc1385a2095573e3f09bba07087..29375a7ec8a982fe9fa7da6014f4c92c19aa3a93 100644

--- a/chrome/browser/profiles/profile_manager_unittest.cc

+++ b/chrome/browser/profiles/profile_manager_unittest.cc

@@ -300,9 +300,9 @@ TEST_F(ProfileManagerTest, CreateAndUseTwoProfiles) {

EXPECT_TRUE(HistoryServiceFactory::GetForProfile(

profile1, ServiceAccessType::EXPLICIT_ACCESS));

profile1->CreateBookmarkModel(true);

- EXPECT_TRUE(BookmarkModelFactory::GetForProfile(profile1));

+ EXPECT_TRUE(BookmarkModelFactory::GetForBrowserContext(profile1));

profile2->CreateBookmarkModel(true);

- EXPECT_TRUE(BookmarkModelFactory::GetForProfile(profile2));

+ EXPECT_TRUE(BookmarkModelFactory::GetForBrowserContext(profile2));

ASSERT_TRUE(profile2->CreateHistoryService(true, false));

EXPECT_TRUE(HistoryServiceFactory::GetForProfile(

profile2, ServiceAccessType::EXPLICIT_ACCESS));