chrome/browser/importer/profile_writer_unittest.cc - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/importer/profile_writer_unittest.cc

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Eliminate Profile::FromBrowserContext in some places Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/history/android/android_history_provider_service_unittest.cc ('K') | « chrome/browser/importer/profile_writer.cc ('k') | chrome/browser/profiles/profile_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/importer/profile_writer_unittest.cc

diff --git a/chrome/browser/importer/profile_writer_unittest.cc b/chrome/browser/importer/profile_writer_unittest.cc

index 8bfc115029533b95cbe385c452f3d44c8ca97752..dbed31920cc0dbaba88758c02983c4c22887a2e1 100644

--- a/chrome/browser/importer/profile_writer_unittest.cc

+++ b/chrome/browser/importer/profile_writer_unittest.cc

@@ -138,7 +138,7 @@ TEST_F(ProfileWriterTest, CheckBookmarksWithMultiProfile) {

profile2.CreateBookmarkModel(true);

BookmarkModel* bookmark_model2 =

- BookmarkModelFactory::GetForProfile(&profile2);

+ BookmarkModelFactory::GetForBrowserContext(&profile2);

bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model2);

bookmarks::AddIfNotBookmarked(

bookmark_model2, GURL("http://www.bing.com"), base::ASCIIToUTF16("Bing"));

@@ -147,7 +147,7 @@ TEST_F(ProfileWriterTest, CheckBookmarksWithMultiProfile) {

CreateImportedBookmarksEntries();

BookmarkModel* bookmark_model1 =

- BookmarkModelFactory::GetForProfile(&profile1);

+ BookmarkModelFactory::GetForBrowserContext(&profile1);

bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model1);

scoped_refptr<TestProfileWriter> profile_writer(

@@ -171,7 +171,7 @@ TEST_F(ProfileWriterTest, CheckBookmarksAfterWritingDataTwice) {

CreateImportedBookmarksEntries();

BookmarkModel* bookmark_model =

- BookmarkModelFactory::GetForProfile(&profile);

+ BookmarkModelFactory::GetForBrowserContext(&profile);

bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model);

scoped_refptr<TestProfileWriter> profile_writer(