chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Eliminate Profile::FromBrowserContext in some places Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/history/android/android_history_provider_service_unittest.cc ('K') | « chrome/browser/history/android/bookmark_model_sql_handler.cc ('k') | chrome/browser/history/android/sqlite_cursor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc

diff --git a/chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc b/chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc

index 529f98264f7724e59c3e9bcb13cd6bdb6fbb043a..52d6ccac13950759d9989c62ac7b3a0501ed74b8 100644

--- a/chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc

+++ b/chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc

@@ -48,7 +48,8 @@ class BookmarkModelSQLHandlerTest : public testing::Test {

chrome::kInitialProfile);

// Create the BookmarkModel that doesn't need to invoke load().

testing_profile->CreateBookmarkModel(true);

- bookmark_model_ = BookmarkModelFactory::GetForProfile(testing_profile);

+ bookmark_model_ =

+ BookmarkModelFactory::GetForBrowserContext(testing_profile);

bookmarks::test::WaitForBookmarkModelToLoad(bookmark_model_);

ASSERT_TRUE(bookmark_model_);

// Get the BookmarkModel from LastUsedProfile, this is the same way that