chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Eliminate Profile::FromBrowserContext in some places Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc ('k') | chrome/browser/extensions/api/bookmarks/bookmark_api_helpers_unittest.cc » ('j') | chrome/browser/history/android/android_history_provider_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

diff --git a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

index 1ec66b72e41c4b3324f84dc2da9ed528ff524485..c64ba831db188acf2d4c00017ad7680f16642f10 100644

--- a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

+++ b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

@@ -35,7 +35,7 @@ using bookmarks::BookmarkNode;

IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_BookmarkManager) {

// Add managed bookmarks.

Profile* profile = browser()->profile();

- BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile);

+ BookmarkModel* model = BookmarkModelFactory::GetForBrowserContext(profile);

bookmarks::ManagedBookmarkService* managed =

ManagedBookmarkServiceFactory::GetForProfile(profile);

bookmarks::test::WaitForBookmarkModelToLoad(model);

@@ -61,7 +61,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, BookmarkManagerEditDisabled) {

// Provide some testing data here, since bookmark editing will be disabled

// within the extension.

- BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile);

+ BookmarkModel* model = BookmarkModelFactory::GetForBrowserContext(profile);

bookmarks::test::WaitForBookmarkModelToLoad(model);

const BookmarkNode* bar = model->bookmark_bar_node();

const BookmarkNode* folder =