chrome/browser/autocomplete/in_memory_url_index_factory.cc - Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/in_memory_url_index_factory.cc

Issue 2216713002: Use BookmarkModelFactory::GetForBrowserContext everywhere (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bookmarks

Patch Set: Eliminate Profile::FromBrowserContext in some places Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/chrome_autocomplete_provider_client.cc ('k') | chrome/browser/bookmarks/bookmark_html_writer.cc » ('j') | chrome/browser/history/android/android_history_provider_service_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/in_memory_url_index_factory.cc

diff --git a/chrome/browser/autocomplete/in_memory_url_index_factory.cc b/chrome/browser/autocomplete/in_memory_url_index_factory.cc

index 42a43e38626678e0eba17303b58217c42d3a9934..95849abd1c0a1637257eb9467ea15905234fbc93 100644

--- a/chrome/browser/autocomplete/in_memory_url_index_factory.cc

+++ b/chrome/browser/autocomplete/in_memory_url_index_factory.cc

@@ -45,13 +45,13 @@ KeyedService* InMemoryURLIndexFactory::BuildServiceInstanceFor(

Profile* profile = Profile::FromBrowserContext(context);

SchemeSet chrome_schemes_to_whitelist;

chrome_schemes_to_whitelist.insert(content::kChromeUIScheme);

- InMemoryURLIndex* in_memory_url_index = new InMemoryURLIndex(

- BookmarkModelFactory::GetForProfile(profile),

- HistoryServiceFactory::GetForProfile(profile,

- ServiceAccessType::IMPLICIT_ACCESS),

- TemplateURLServiceFactory::GetForProfile(profile),

- content::BrowserThread::GetBlockingPool(), profile->GetPath(),

- chrome_schemes_to_whitelist);

+ InMemoryURLIndex* in_memory_url_index =

+ new InMemoryURLIndex(BookmarkModelFactory::GetForBrowserContext(profile),

+ HistoryServiceFactory::GetForProfile(

+ profile, ServiceAccessType::IMPLICIT_ACCESS),

+ TemplateURLServiceFactory::GetForProfile(profile),

+ content::BrowserThread::GetBlockingPool(),

+ profile->GetPath(), chrome_schemes_to_whitelist);

in_memory_url_index->Init();

return in_memory_url_index;

}