Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2216703002: Enforce green on travis with dev analyzer (Closed)

Created:
4 years, 4 months ago by vsm
Modified:
4 years, 4 months ago
Reviewers:
Leaf, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enforce green on travis with dev analyzer Note, tip analyzer is red - the analyzer is now type checking a test that used to statically fail: Chrome 54.0.2818 (Linux 0.0.0) recursive_inheritance_test FAILED Error: test marked as 'notyetstrong' due to strong mode errors, but passed R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/057a9c8ad213fc51959093f31bfed3ca972a8eab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M .travis.yml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
vsm
4 years, 4 months ago (2016-08-04 16:48:56 UTC) #3
Leaf
lgtm
4 years, 4 months ago (2016-08-04 16:50:04 UTC) #4
vsm
4 years, 4 months ago (2016-08-04 16:52:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
057a9c8ad213fc51959093f31bfed3ca972a8eab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698