Cleanup: Remove unnecessary property: VolumeList.currentVolume_

chrome/browser/resources/file_manager/js/volume_list.js

Index: chrome/browser/resources/file_manager/js/volume_list.js
diff --git a/chrome/browser/resources/file_manager/js/volume_list.js b/chrome/browser/resources/file_manager/js/volume_list.js
index e27301c40cd03e2753c286c7b83605a754dd77d1..f2cbc88aa4f6c6500ba6a703caa81aa6d7c41f14 100644
--- a/chrome/browser/resources/file_manager/js/volume_list.js
+++ b/chrome/browser/resources/file_manager/js/volume_list.js
@@ -186,8 +186,6 @@ VolumeList.prototype.decorate = function(directoryModel, pinnedFolderModel) {
       'change', this.onSelectionChange_.bind(this));
   this.selectionModel.addEventListener(
       'beforeChange', this.onBeforeSelectionChange_.bind(this));
-  this.currentVolume_ = null;
-
 
   this.scrollBar_ = new ScrollBar();
   this.scrollBar_.initialize(this.parentNode, this);
@@ -314,11 +312,10 @@ VolumeList.prototype.selectByIndex = function(index) {
     return false;
 
   var newPath = this.dataModel.item(index);
-  if (!newPath || this.currentVolume_ == newPath)
+  if (!newPath || this.directoryModel.getCurrentDirEntry().fullPath == newPath)

[mtomasz, 2013/08/05 12:17:57]

directoryModel -> directoryModel_

[mtomasz, 2013/08/05 12:17:57]

I think this will not work as it should. getCurrentDirEntry().fullPath will
return the current path, not the current root.

[yoshiki, 2013/08/05 16:08:01]

Done.

[yoshiki, 2013/08/05 16:08:01]

It should work. Previous code was wrong.

Before introducing folder shortcut feature, each root had only an item. If the
selection is changed, the roots of old and new items must be different. But now,
there may be two or more items with same root, so comparing root is not enough.
We need to compare the entire path.

[mtomasz, 2013/08/05 16:25:52]

I see. My concern is that this check was used to avoid reselecting the current
item I guess. Now, it will sometimes allow to reselect and sometimes not. Eg.
when we are in a subdirectory of Drive and then try to change to Drive. This
check will return false and will allow to reselect.

So, I have two questions:
1. Is this check necessary? If not, then can we remove it?
2. Why not checking the selection model if the current selected index == index?

If we can't (1) nor (2) then please just add a comment describing the purpose of
this check.

     return false;
 
-  this.currentVolume_ = newPath;
-  this.directoryModel_.changeDirectory(this.currentVolume_);
+  this.directoryModel_.changeDirectory(newPath);
   return true;
 };
 
@@ -355,10 +352,6 @@ VolumeList.prototype.onCurrentDirectoryChanged_ = function(event) {
   var path = event.newDirEntry.fullPath || this.dataModel.getCurrentDirPath();
   var newRootPath = PathUtil.getRootPath(path);
 
-  // Sets |this.currentVolume_| in advance to prevent |onSelectionChange_()|
-  // from calling |DirectoryModel.ChangeDirectory()| again.
-  this.currentVolume_ = newRootPath;
-
   // Synchronizes the volume list selection with the current directory, after
   // it is changed outside of the volume list.