Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2216683002: [M53][NTP Client] Fix test compilation on branch (Closed)

Created:
4 years, 4 months ago by dgn
Modified:
4 years, 4 months ago
Reviewers:
Bernhard Bauer, gordana.cmiljanovic, kerz_chromium, kerz_google
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[M53][NTP Client] Fix test compilation on branch Fix the inconsistent class name usage introduced by https://codereview.chromium.org/2166753003 BUG=626831 NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dgn
PTAL
4 years, 4 months ago (2016-08-04 16:34:26 UTC) #3
Bernhard Bauer
LGTM (you might need TPM approval to land, but it's test-only).
4 years, 4 months ago (2016-08-04 16:38:17 UTC) #4
dgn
kerz@: PTAL for TPM approval. This is to fix a test only issue: http://www.rt-rk.com/mips-buildbot/builders/Release%20branch%20build/builds/1342/steps/Build/logs/stdio
4 years, 4 months ago (2016-08-04 16:48:29 UTC) #6
kerz_google
On 2016/08/04 16:48:29, dgn wrote: > kerz@: PTAL for TPM approval. This is to fix ...
4 years, 4 months ago (2016-08-04 17:09:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216683002/1
4 years, 4 months ago (2016-08-04 17:41:43 UTC) #9
dgn
On 2016/08/04 17:09:51, kerz_google wrote: > On 2016/08/04 16:48:29, dgn wrote: > > kerz@: PTAL ...
4 years, 4 months ago (2016-08-04 17:43:20 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 17:44:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698