Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2216643002: Rename GrDrawingManager::drawContext to makeDrawContext (Closed)

Created:
4 years, 4 months ago by robertphillips
Modified:
4 years, 4 months ago
Reviewers:
jvanverth1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename GrDrawingManager::drawContext to makeDrawContext This was violating our naming convention GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2216643002 Committed: https://skia.googlesource.com/skia/+/29f9fe45ef0a7994f6f46c55d288bbdb696295f3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
M src/gpu/GrContext.cpp View 4 chunks +11 lines, -8 lines 0 comments Download
M src/gpu/GrDrawingManager.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrDrawingManager.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
robertphillips
4 years, 4 months ago (2016-08-04 14:00:07 UTC) #4
robertphillips
ping
4 years, 4 months ago (2016-08-05 12:42:30 UTC) #9
jvanverth1
lgtm
4 years, 4 months ago (2016-08-05 15:45:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216643002/1
4 years, 4 months ago (2016-08-05 16:03:06 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 16:28:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/29f9fe45ef0a7994f6f46c55d288bbdb696295f3

Powered by Google App Engine
This is Rietveld 408576698