Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 221663004: mojo: add handle<shared_buffer> support to generator (Closed)

Created:
6 years, 8 months ago by piman
Modified:
6 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

mojo: add handle<shared_buffer> support to generator BUG=333157 R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -114 lines) Patch
M mojo/public/bindings/generators/mojom_cpp_generator.py View 3 chunks +20 lines, -15 lines 0 comments Download
M mojo/public/bindings/generators/mojom_js_generator.py View 4 chunks +68 lines, -64 lines 0 comments Download
M mojo/public/bindings/pylib/generate/mojom.py View 2 chunks +19 lines, -17 lines 0 comments Download
M mojo/public/bindings/pylib/generate/mojom_pack.py View 1 chunk +17 lines, -16 lines 0 comments Download
M mojo/public/bindings/pylib/parse/mojo_lexer.py View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/bindings/pylib/parse/mojo_parser.py View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/bindings/pylib/parse/mojo_translate.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
piman
6 years, 8 months ago (2014-04-02 01:20:38 UTC) #1
darin (slow to review)
LGTM
6 years, 8 months ago (2014-04-02 05:32:32 UTC) #2
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 8 months ago (2014-04-02 06:34:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/221663004/1
6 years, 8 months ago (2014-04-02 06:35:36 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 10:08:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-02 10:08:18 UTC) #6
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 8 months ago (2014-04-02 16:01:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/221663004/1
6 years, 8 months ago (2014-04-02 16:02:57 UTC) #8
piman
6 years, 8 months ago (2014-04-02 23:50:15 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r261226 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698