Issue 221663002: MediaQueryList::evaluate should return a bool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 221663002: MediaQueryList::evaluate should return a bool (Closed)

Created:
6 years, 8 months ago by esprehn

Modified:
6 years, 8 months ago

Reviewers:
ojan, eseidel

CC:
blink-reviews, kenneth.christiansen, ed+blinkwatch_opera.com, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, Yoav Weiss

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

MediaQueryList::evaluate should return a bool Instead of passing a boolean by reference we should just return one. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170620

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -6 lines)			Patch
M	Source/core/css/MediaQueryList.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/css/MediaQueryList.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/MediaQueryMatcher.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/221663002/1

6 years, 8 months ago (2014-04-02 00:14:38 UTC) #5

esprehn

On 2014/04/01 23:59:00, eseidel wrote: > rslgtm. I have a bunch of patches to make ...

6 years, 8 months ago (2014-04-02 00:14:59 UTC) #6

Message was sent while issue was closed.

Change committed as 170620

Expand Messages | Collapse Messages