third_party/WebKit/LayoutTests/bluetooth/notifications/start-succeeds.html - Issue 2216623002: bluetooth: {start,stop}Notifications() return the characteristic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/notifications/start-succeeds.html

Issue 2216623002: bluetooth: {start,stop}Notifications() return the characteristic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change WeakPersistent to Persistent Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/bluetooth/notifications/stop-after-start-succeeds.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/bluetooth/notifications/start-succeeds.html

diff --git a/third_party/WebKit/LayoutTests/bluetooth/notifications/start-succeeds.html b/third_party/WebKit/LayoutTests/bluetooth/notifications/start-succeeds.html

index df8826536f8ab5aaac563836e8235bb4a83181d4..eff0ec8692fdc3199588574fd2a84a5522eb8bc5 100644

--- a/third_party/WebKit/LayoutTests/bluetooth/notifications/start-succeeds.html

+++ b/third_party/WebKit/LayoutTests/bluetooth/notifications/start-succeeds.html

@@ -11,7 +11,13 @@ promise_test(() => {

.then(device => device.gatt.connect())

.then(gattServer => gattServer.getPrimaryService('heart_rate'))

.then(service => service.getCharacteristic('heart_rate_measurement'))

- .then(characteristic => characteristic.startNotifications());

+ .then(characteristic => {

+ return characteristic.startNotifications()

+ .then(start_characteristic => {

+ assert_equals(start_characteristic, characteristic,

+ 'Start characteristic should be the same as characteristic.');

+ });

// TODO(ortuno): Assert that notifications are active.

// http://crbug.com/600762

}, 'Single start notifications succeeds.');