third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl - Issue 2216623002: bluetooth: {start,stop}Notifications() return the characteristic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl

Issue 2216623002: bluetooth: {start,stop}Notifications() return the characteristic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp ('K') | « third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl

index a47a50e93afda198b40392d4230d87e73b586846..8ee4fbb88fa78ff58094badff4dfe9f404196d7e 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.idl

@@ -16,10 +16,10 @@

readonly attribute DataView? value;

// Promise<BluetoothRemoteGATTDescriptor> getDescriptor(BluetoothDescriptorUUID descriptor);

// Promise<sequence<BluetoothRemoteGATTDescriptor>> getDescriptors(optional BluetoothDescriptorUUID descriptor);

- [CallWith=ScriptState] Promise<DataView> readValue();

- [CallWith=ScriptState] Promise<void> writeValue(BufferSource value);

- [CallWith=ScriptState] Promise<void> startNotifications();

- [CallWith=ScriptState] Promise<void> stopNotifications();

+ [CallWith=ScriptState] Promise<DataView> readValue();

ortuno 2016/08/05 01:43:44 nit: Line this up, I think.

François Beaufort 2016/08/05 06:41:15 Done.

+ [CallWith=ScriptState] Promise<void> writeValue(BufferSource value);

+ [CallWith=ScriptState] Promise<BluetoothRemoteGATTCharacteristic> startNotifications();

+ [CallWith=ScriptState] Promise<BluetoothRemoteGATTCharacteristic> stopNotifications();

// TODO(ortuno): Move this to CharacteristicEventHandlers.

// http://crbug.com/537459