Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1500)

Issue 2216563002: [Bindings] Increase the number of aggregated files (Closed)

Created:
4 years, 4 months ago by peria
Modified:
4 years, 4 months ago
Reviewers:
haraken, tzik, Yuki, bashi
CC:
chromium-reviews, blink-reviews, Dirk Pranke, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase the number of files to aggregate generated .cpp files from .idl files. (This change is a workaround change.) It is expected to reduce compile time because of following reasons. - The number of lines to be processed in one compile reduced. - The number of compile tasks increased, so they can be run in parallel. BUG=634231 Committed: https://crrev.com/a77ec79a00851a95760c94c0fe9daa02ce44ab6c Cr-Commit-Position: refs/heads/master@{#409809}

Patch Set 1 #

Patch Set 2 : increase the number of modules #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/generated.gni View 2 chunks +61 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/generated.gypi View 2 chunks +61 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/generated.gni View 1 2 chunks +61 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/generated.gypi View 1 2 chunks +61 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
peria
PTL
4 years, 4 months ago (2016-08-04 09:46:22 UTC) #3
bashi
I'm fine with this CL if other reviewers are happy with it :) Do we ...
4 years, 4 months ago (2016-08-04 09:51:32 UTC) #4
Yuki
lgtm
4 years, 4 months ago (2016-08-04 09:53:49 UTC) #5
peria
I found that this change breaks the build system, because some generated files does not ...
4 years, 4 months ago (2016-08-04 10:03:54 UTC) #6
tzik
lgtm
4 years, 4 months ago (2016-08-04 12:32:23 UTC) #7
haraken
LGTM. Yes, I've wanted to make this change for a long time :)
4 years, 4 months ago (2016-08-04 13:11:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216563002/20001
4 years, 4 months ago (2016-08-04 15:22:20 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-04 16:44:44 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 16:47:43 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a77ec79a00851a95760c94c0fe9daa02ce44ab6c
Cr-Commit-Position: refs/heads/master@{#409809}

Powered by Google App Engine
This is Rietveld 408576698