Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4166)

Unified Diff: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc

Issue 22165002: Change the meaning of SelectFileDialog.support_drive: it means Drive-aware callers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
diff --git a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
index 592fceda688946f21c8550b29cb77da03b79d4d5..a6a2d2affce99650edaf7d8e6642a36534359d91 100644
--- a/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
+++ b/chrome/browser/extensions/api/bookmarks/bookmarks_api.cc
@@ -945,8 +945,6 @@ void BookmarksIOFunction::ShowSelectFileDialog(
ui::SelectFileDialog::FileTypeInfo file_type_info;
file_type_info.extensions.resize(1);
file_type_info.extensions[0].push_back(FILE_PATH_LITERAL("html"));
- // TODO(kinaba): http://crbug.com/140425. Turn file_type_info.support_drive
- // on for saving once Google Drive client on ChromeOS supports it.
gfx::NativeWindow owning_window = web_contents ?
platform_util::GetTopLevel(web_contents->GetView()->GetNativeView())
: NULL;
@@ -955,8 +953,6 @@ void BookmarksIOFunction::ShowSelectFileDialog(
chrome::GetActiveDesktop() == chrome::HOST_DESKTOP_TYPE_ASH)
owning_window = aura::RemoteRootWindowHostWin::Instance()->GetAshWindow();
#endif
- if (type == ui::SelectFileDialog::SELECT_OPEN_FILE)
- file_type_info.support_drive = true;
// |web_contents| can be NULL (for background pages), which is fine. In such
// a case if file-selection dialogs are forbidden by policy, we will not
// show an InfoBar, which is better than letting one appear out of the blue.

Powered by Google App Engine
This is Rietveld 408576698