Change the meaning of SelectFileDialog.support_drive: it means Drive-aware callers.

chrome/browser/chromeos/extensions/file_manager/private_api_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_manager/private_api_util.h"
 
 #include "base/files/file_path.h"
 #include "chrome/browser/chromeos/drive/drive.pb.h"
 #include "chrome/browser/chromeos/drive/drive_integration_service.h"
 #include "chrome/browser/chromeos/drive/file_errors.h"
@@ skipping 13 matching lines @@
 
 using content::BrowserThread;
 using google_apis::InstalledApp;
 
 namespace file_manager {
 namespace util {
 namespace {
 
 // The struct is used for GetSelectedFileInfo().
 struct GetSelectedFileInfoParams {
-  bool for_opening;
+  GetSelectedFileInfoLocalPathOption local_path_option;
   GetSelectedFileInfoCallback callback;
   std::vector<base::FilePath> file_paths;
   std::vector<ui::SelectedFileInfo> selected_files;
 };
 
 // Forward declarations of helper functions for GetSelectedFileInfo().
 void ContinueGetSelectedFileInfo(Profile* profile,
                                  scoped_ptr<GetSelectedFileInfoParams> params,
                                  drive::FileError error,
                                  const base::FilePath& local_file_path,
                                  scoped_ptr<drive::ResourceEntry> entry);
 
 // Part of GetSelectedFileInfo().
 void GetSelectedFileInfoInternal(Profile* profile,
                                  scoped_ptr<GetSelectedFileInfoParams> params) {
   DCHECK(profile);
 
   for (size_t i = params->selected_files.size();
        i < params->file_paths.size(); ++i) {
     const base::FilePath& file_path = params->file_paths[i];
-    // When opening a drive file, we should get local file path.
-    if (params->for_opening &&
-        drive::util::IsUnderDriveMountPoint(file_path)) {
+    // When the caller of the select file dialog wants local file paths,
+    // we should retrieve Drive files onto the local cache.
+    if (params->local_path_option == NO_LOCAL_PATH_RESOLUTION ||
+        !drive::util::IsUnderDriveMountPoint(file_path)) {
+      params->selected_files.push_back(
+          ui::SelectedFileInfo(file_path, base::FilePath()));
+    } else {
       drive::DriveIntegrationService* integration_service =
           drive::DriveIntegrationServiceFactory::GetForProfile(profile);
       // |integration_service| is NULL if Drive is disabled.
       if (!integration_service) {
         ContinueGetSelectedFileInfo(profile,
                                     params.Pass(),
                                     drive::FILE_ERROR_FAILED,
                                     base::FilePath(),
                                     scoped_ptr<drive::ResourceEntry>());
         return;
       }
+      // TODO(kinaba): crbug.com/140425 support FOR_SAVING
+      DCHECK(params->local_path_option == NEED_LOCAL_PATH_FOR_OPENING);
       integration_service->file_system()->GetFileByPath(
           drive::util::ExtractDrivePath(file_path),
           base::Bind(&ContinueGetSelectedFileInfo,
                      profile,
                      base::Passed(&params)));
       return;
-    } else {
-      params->selected_files.push_back(
-          ui::SelectedFileInfo(file_path, base::FilePath()));
     }
   }
   params->callback.Run(params->selected_files);
 }
 
 // Part of GetSelectedFileInfo().
 void ContinueGetSelectedFileInfo(Profile* profile,
                                  scoped_ptr<GetSelectedFileInfoParams> params,
                                  drive::FileError error,
                                  const base::FilePath& local_file_path,
@@ skipping 62 matching lines @@
       file_system_context->CrackURL(url));
   base::FilePath path;
   if (!chromeos::FileSystemBackend::CanHandleURL(filesystem_url))
     return base::FilePath();
   return filesystem_url.path();
 }
 
 void GetSelectedFileInfo(content::RenderViewHost* render_view_host,
                          Profile* profile,
                          const std::vector<GURL>& file_urls,
-                         bool for_opening,
+                         GetSelectedFileInfoLocalPathOption local_path_option,
                          GetSelectedFileInfoCallback callback) {
   DCHECK(render_view_host);
   DCHECK(profile);
 
   scoped_ptr<GetSelectedFileInfoParams> params(new GetSelectedFileInfoParams);
-  params->for_opening = for_opening;
+  params->local_path_option = local_path_option;
   params->callback = callback;
 
   for (size_t i = 0; i < file_urls.size(); ++i) {
     const GURL& file_url = file_urls[i];
     const base::FilePath path = GetLocalPathFromURL(
         render_view_host, profile, file_url);
     if (!path.empty()) {
       DVLOG(1) << "Selected: file path: " << path.value();
       params->file_paths.push_back(path);
     }
   }
 
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
       base::Bind(&GetSelectedFileInfoInternal,
                  profile,
                  base::Passed(&params)));
 }
 
 }  // namespace util
 }  // namespace file_manager