Change the meaning of SelectFileDialog.support_drive: it means Drive-aware callers.

ui/shell_dialogs/select_file_dialog.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_SHELL_DIALOGS_SELECT_FILE_DIALOG_H_
 #define UI_SHELL_DIALOGS_SELECT_FILE_DIALOG_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 110 matching lines @@
 
     // Overrides the system descriptions of the specified extensions. Entries
     // correspond to |extensions|; if left blank the system descriptions will
     // be used.
     std::vector<base::string16> extension_description_overrides;
 
     // Specifies whether there will be a filter added for all files (i.e. *.*).
     bool include_all_files;
 
     // Specifies whether the caller can support files/folders that are on Drive.
+    // When this flag is false, the file dialog provides a local snapshot copy
+    // of selected files so that the caller can operate on it transparently.

[satorux1, 2013/08/06 02:07:17]

More comment? If I understand correctly, Drive is now supported in most cases,
but there would be two ways to handle Drive.

Maybe rename the flag to something more relevant to the new meaning?

[kinaba, 2013/08/06 06:20:56]

Added more comments.
I think the name is still relevant. Turning off the flag indicates
that the caller does not handle Drive files so the file dialog must
do something.

     bool support_drive;
   };
 
   // Selects a File.
   // Before doing anything this function checks if FileBrowsing is forbidden
   // by Policy. If so, it tries to show an InfoBar and behaves as though no File
   // was selected (the user clicked `Cancel` immediately).
   // Otherwise it will start displaying the dialog box. This will also
   // block the calling window until the dialog box is complete. The listener
   // associated with this object will be notified when the selection is
@@ skipping 69 matching lines @@
   virtual bool HasMultipleFileTypeChoicesImpl() = 0;
 
   scoped_ptr<SelectFilePolicy> select_file_policy_;
 
   DISALLOW_COPY_AND_ASSIGN(SelectFileDialog);
 };
 
 }  // namespace ui
 
 #endif  // UI_SHELL_DIALOGS_SELECT_FILE_DIALOG_H_