Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2216473002:
Roll WebGL e3488c3..b57946d (Closed)
DescriptionRoll WebGL e3488c3..b57946d
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/e3488c3..b57946d
BUG=
TEST=bots
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel
Committed: https://crrev.com/933d3b076a4019ae87b5bffd03d5430e6e122f06
Cr-Commit-Position: refs/heads/master@{#409940}
Patch Set 1 #Messages
Total messages: 16 (9 generated)
Description was changed from ========== Roll WebGL e3488c3..b57946d https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/e3488c... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ========== to ========== Roll WebGL e3488c3..b57946d https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/e3488c... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ==========
yunchao.he@intel.com changed reviewers: + kbr@chromium.org, zmo@chromium.org
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Roll in my patch about mutisample floating-point internal format for renderbuffer in WebGL 2 CTS: https://github.com/KhronosGroup/WebGL/pull/1946. Test it against jie's CL https://codereview.chromium.org/2197893003/ in Chromium on all gpu bots. It turned out that all bots are green. PTAL. Thanks a lot!
On 2016/08/04 08:08:12, yunchao wrote: > Roll in my patch about mutisample floating-point internal format for > renderbuffer in WebGL 2 CTS: https://github.com/KhronosGroup/WebGL/pull/1946. > Test it against jie's CL https://codereview.chromium.org/2197893003/ in Chromium > on all gpu bots. It turned out that all bots are green. > > PTAL. Thanks a lot! Jie told me that Linux Intel mesa have issue with these two patches applied. Maybe your waterfall bots will catch that issue. I think it is a driver bug in mesa project. We will report that issue to Intel mesa team.
On 2016/08/04 08:15:57, yunchao wrote: > On 2016/08/04 08:08:12, yunchao wrote: > > Roll in my patch about mutisample floating-point internal format for > > renderbuffer in WebGL 2 CTS: https://github.com/KhronosGroup/WebGL/pull/1946. > > Test it against jie's CL https://codereview.chromium.org/2197893003/ in > Chromium > > on all gpu bots. It turned out that all bots are green. > > > > PTAL. Thanks a lot! > > Jie told me that Linux Intel mesa have issue with these two patches applied. > Maybe your waterfall bots will catch that issue. > I think it is a driver bug in mesa project. We will report that issue to Intel > mesa team. lgtm Can you watch the Linux Intel bot and update the test expectations accordingly after this lands? http://build.chromium.org/p/chromium.gpu.fyi/waterfall?builder=Linux%20Releas...
The CQ bit was checked by yunchao.he@intel.com
On 2016/08/04 18:32:49, Zhenyao Mo wrote: > On 2016/08/04 08:15:57, yunchao wrote: > > On 2016/08/04 08:08:12, yunchao wrote: > > > Roll in my patch about mutisample floating-point internal format for > > > renderbuffer in WebGL 2 CTS: > https://github.com/KhronosGroup/WebGL/pull/1946. > > > Test it against jie's CL https://codereview.chromium.org/2197893003/ in > > Chromium > > > on all gpu bots. It turned out that all bots are green. > > > > > > PTAL. Thanks a lot! > > > > Jie told me that Linux Intel mesa have issue with these two patches applied. > > Maybe your waterfall bots will catch that issue. > > I think it is a driver bug in mesa project. We will report that issue to Intel > > mesa team. > > lgtm > > Can you watch the Linux Intel bot and update the test expectations accordingly > after this lands? > > http://build.chromium.org/p/chromium.gpu.fyi/waterfall?builder=Linux%20Releas... No problem, @zmo. I will update the expectations accordingly. Merging now...
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Roll WebGL e3488c3..b57946d https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/e3488c... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ========== to ========== Roll WebGL e3488c3..b57946d https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/e3488c... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll WebGL e3488c3..b57946d https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/e3488c... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ========== to ========== Roll WebGL e3488c3..b57946d https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/e3488c... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel Committed: https://crrev.com/933d3b076a4019ae87b5bffd03d5430e6e122f06 Cr-Commit-Position: refs/heads/master@{#409940} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/933d3b076a4019ae87b5bffd03d5430e6e122f06 Cr-Commit-Position: refs/heads/master@{#409940} |
