Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1816)

Unified Diff: components/autofill/content/renderer/renderer_save_password_progress_logger.h

Issue 2216463002: [Autofill] Migrate ContentPasswordManagerDriver<-->Password{Autofill,Generation}Agent IPCs to mojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nit from Vaclav Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/renderer_save_password_progress_logger.h
diff --git a/components/autofill/content/renderer/renderer_save_password_progress_logger.h b/components/autofill/content/renderer/renderer_save_password_progress_logger.h
index bccfd1b0ef5f02fa68433ad5247bb81911e1f96b..2ebe2b52900435c19f46005426af0bfe5e5a19b2 100644
--- a/components/autofill/content/renderer/renderer_save_password_progress_logger.h
+++ b/components/autofill/content/renderer/renderer_save_password_progress_logger.h
@@ -8,28 +8,23 @@
#include <string>
#include "base/macros.h"
+#include "components/autofill/content/public/interfaces/autofill_driver.mojom.h"
#include "components/autofill/core/common/save_password_progress_logger.h"
-class PasswordManagerClient;
-
namespace blink {
class WebFormControlElement;
}
-namespace IPC {
-class Sender;
-}
-
namespace autofill {
// This is the SavePasswordProgressLogger specialization for the renderer code,
// which sends logs to the browser process over IPC.
class RendererSavePasswordProgressLogger : public SavePasswordProgressLogger {
public:
- // The logger will use |sender| and |routing_id| to send a
- // AutofillHostMsg_RecordSavePasswordProgress message with the logs to the
- // browser. The |sender| needs to outlive the constructed logger.
- RendererSavePasswordProgressLogger(IPC::Sender* sender, int routing_id);
+ // The logger will use |password_manager_driver| to send logs to the browser.
+ // The |password_manager_driver| needs to outlive the constructed logger.
+ RendererSavePasswordProgressLogger(
+ mojom::PasswordManagerDriver* password_manager_driver);
~RendererSavePasswordProgressLogger() override;
void LogElementName(StringID label,
@@ -40,10 +35,9 @@ class RendererSavePasswordProgressLogger : public SavePasswordProgressLogger {
void SendLog(const std::string& log) override;
private:
- // Used by SendLog to send the IPC message with logs. |sender_| needs to
- // outlive the logger.
- IPC::Sender* const sender_;
- const int routing_id_;
+ // Used by SendLog to send the logs to the browser.
+ // |password_manager_driver_| needs to outlive the logger.
+ mojom::PasswordManagerDriver* password_manager_driver_;
DISALLOW_COPY_AND_ASSIGN(RendererSavePasswordProgressLogger);
};

Powered by Google App Engine
This is Rietveld 408576698