components/autofill/content/browser/content_autofill_driver.cc - Issue 2216463002: [Autofill] Migrate ContentPasswordManagerDriver<-->Password{Autofill,Generation}Agent IPCs to mojo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/browser/content_autofill_driver.cc

Issue 2216463002: [Autofill] Migrate ContentPasswordManagerDriver<-->Password{Autofill,Generation}Agent IPCs to mojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nit from Vaclav Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/browser/content_autofill_driver.h ('k') | components/autofill/content/browser/content_autofill_driver_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/browser/content_autofill_driver.cc

diff --git a/components/autofill/content/browser/content_autofill_driver.cc b/components/autofill/content/browser/content_autofill_driver.cc

index 3f4ce7928c9ad4461bef10694c7efe41504344e5..2821197efa4ea6a442c5a617b19d0470a49f5439 100644

--- a/components/autofill/content/browser/content_autofill_driver.cc

+++ b/components/autofill/content/browser/content_autofill_driver.cc

@@ -9,7 +9,6 @@

#include "base/command_line.h"

#include "base/threading/sequenced_worker_pool.h"

#include "components/autofill/content/browser/content_autofill_driver_factory.h"

-#include "components/autofill/content/common/autofill_messages.h"

#include "components/autofill/core/browser/autofill_client.h"

#include "components/autofill/core/browser/autofill_external_delegate.h"

#include "components/autofill/core/browser/autofill_manager.h"

@@ -254,12 +253,12 @@ void ContentAutofillDriver::NotifyFirstUserGestureObservedInTab() {

const mojom::AutofillAgentPtr& ContentAutofillDriver::GetAutofillAgent() {

// Here is a lazy binding, and will not reconnect after connection error.

- if (!mojo_autofill_agent_) {

+ if (!autofill_agent_) {

render_frame_host_->GetRemoteInterfaces()->GetInterface(

- mojo::GetProxy(&mojo_autofill_agent_));

+ mojo::GetProxy(&autofill_agent_));

}

- return mojo_autofill_agent_;

+ return autofill_agent_;

}

} // namespace autofill