Chromium Code Reviews| Index: components/autofill/content/renderer/renderer_save_password_progress_logger.h |
| diff --git a/components/autofill/content/renderer/renderer_save_password_progress_logger.h b/components/autofill/content/renderer/renderer_save_password_progress_logger.h |
| index bccfd1b0ef5f02fa68433ad5247bb81911e1f96b..d342ecaa1606aa8291956be5e99ef8f11cec208f 100644 |
| --- a/components/autofill/content/renderer/renderer_save_password_progress_logger.h |
| +++ b/components/autofill/content/renderer/renderer_save_password_progress_logger.h |
| @@ -8,28 +8,23 @@ |
| #include <string> |
| #include "base/macros.h" |
| +#include "components/autofill/content/public/interfaces/autofill_driver.mojom.h" |
| #include "components/autofill/core/common/save_password_progress_logger.h" |
| -class PasswordManagerClient; |
| - |
| namespace blink { |
| class WebFormControlElement; |
| } |
| -namespace IPC { |
| -class Sender; |
| -} |
| - |
| namespace autofill { |
| // This is the SavePasswordProgressLogger specialization for the renderer code, |
| // which sends logs to the browser process over IPC. |
| class RendererSavePasswordProgressLogger : public SavePasswordProgressLogger { |
| public: |
| - // The logger will use |sender| and |routing_id| to send a |
| - // AutofillHostMsg_RecordSavePasswordProgress message with the logs to the |
| - // browser. The |sender| needs to outlive the constructed logger. |
| - RendererSavePasswordProgressLogger(IPC::Sender* sender, int routing_id); |
| + // The logger will use |password_manager_driver| to send logs to the browser. |
| + // The |password_manager_driver| needs to outlive the constructed logger. |
| + RendererSavePasswordProgressLogger( |
| + mojom::PasswordManagerDriver* password_manager_driver); |
| ~RendererSavePasswordProgressLogger() override; |
| void LogElementName(StringID label, |
| @@ -40,10 +35,9 @@ class RendererSavePasswordProgressLogger : public SavePasswordProgressLogger { |
| void SendLog(const std::string& log) override; |
| private: |
| - // Used by SendLog to send the IPC message with logs. |sender_| needs to |
| - // outlive the logger. |
| - IPC::Sender* const sender_; |
| - const int routing_id_; |
| + // Used by SendLog to send the IPC message with logs. |
|
vabr (Chromium)
2016/08/09 17:36:17
nit: To avoid confusion, I would drop "IPC message
leonhsl(Using Gerrit)
2016/08/10 13:22:02
Done and thanks.
|
| + // |password_manager_driver_| needs to outlive the logger. |
| + mojom::PasswordManagerDriver* password_manager_driver_; |
| DISALLOW_COPY_AND_ASSIGN(RendererSavePasswordProgressLogger); |
| }; |