[Autofill] Migrate ContentPasswordManagerDriver<-->Password{Autofill,Generation}Agent IPCs to mojo.

components/autofill/content/common/autofill_messages.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Multiply-included message file, hence no include guard.
 
 #include <string>
 #include <vector>
 
 #include "base/strings/string16.h"
 #include "base/time/time.h"
 #include "components/autofill/content/common/autofill_param_traits_macros.h"
 #include "components/autofill/core/common/form_data.h"
 #include "components/autofill/core/common/form_data_predictions.h"

[vabr (Chromium), 2016/08/09 17:36:17]

Looks like most of the structures #included here and described below are no
longer needed. The only exception seems to be PasswordForm, FormData (included
in PF) and FormFieldData (included in FD) + their enums. Could you slim down the
#includes and the IPC traits definitions below to the necessary minimum?

[leonhsl(Using Gerrit), 2016/08/10 13:22:02]

Yeah, Agree. Slim down this file and also cleaned up common/BUILD.gn and
common/DEPS. Done.

 #include "components/autofill/core/common/form_field_data.h"
 #include "components/autofill/core/common/form_field_data_predictions.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/autofill/core/common/password_form_field_prediction_map.h"
 #include "components/autofill/core/common/password_form_fill_data.h"
 #include "components/autofill/core/common/password_form_generation_data.h"
 #include "content/public/common/common_param_traits.h"
 #include "content/public/common/common_param_traits_macros.h"
 #include "ipc/ipc_message_macros.h"
 #include "ipc/ipc_message_utils.h"
@@ skipping 74 matching lines @@
   IPC_STRUCT_TRAITS_MEMBER(other_possible_usernames)
   IPC_STRUCT_TRAITS_MEMBER(wait_for_username)
   IPC_STRUCT_TRAITS_MEMBER(is_possible_change_password_form)
 IPC_STRUCT_TRAITS_END()
 
 IPC_STRUCT_TRAITS_BEGIN(autofill::PasswordAndRealm)
   IPC_STRUCT_TRAITS_MEMBER(password)
   IPC_STRUCT_TRAITS_MEMBER(realm)
 IPC_STRUCT_TRAITS_END()
 
-// Singly-included section for type definitions.
-#ifndef COMPONENTS_AUTOFILL_CONTENT_COMMON_AUTOFILL_MESSAGES_H_
-#define COMPONENTS_AUTOFILL_CONTENT_COMMON_AUTOFILL_MESSAGES_H_
-
-// IPC_MESSAGE macros fail on the std::map, when expanding. We need to define
-// a type to avoid that.
-using FormsPredictionsMap =
-    std::map<autofill::FormData, autofill::PasswordFormFieldPredictionMap>;
-
-#endif  // COMPONENTS_AUTOFILL_CONTENT_COMMON_AUTOFILL_MESSAGES_H_
-
-// Autofill messages sent from the browser to the renderer.
-
-// Fill a password form and prepare field autocomplete for multiple
-// matching logins. Lets the renderer know if it should disable the popup
-// because the browser process will own the popup UI. |key| serves for
-// identifying the fill form data in subsequent
-// AutofillHostMsg_ShowPasswordSuggestions messages to the browser.
-IPC_MESSAGE_ROUTED2(AutofillMsg_FillPasswordForm,
-                    int /* key */,
-                    autofill::PasswordFormFillData /* the fill form data*/)
-
-// Notification to start (|active| == true) or stop (|active| == false) logging
-// the decisions made about saving the password.
-IPC_MESSAGE_ROUTED1(AutofillMsg_SetLoggingState, bool /* active */)
-
-// Tells the renderer to populate the correct password fields with this
-// generated password.
-IPC_MESSAGE_ROUTED1(AutofillMsg_GeneratedPasswordAccepted,
-                    base::string16 /* generated_password */)
-
-// Tells the renderer to enable the form classifier.
-IPC_MESSAGE_ROUTED0(AutofillMsg_AllowToRunFormClassifier)
-
-// Tells the renderer to find the focused password form (assuming it exists).
-// Renderer is expected to respond with the message
-// |AutofillHostMsg_FocusedPasswordFormFound|.
-IPC_MESSAGE_ROUTED0(AutofillMsg_FindFocusedPasswordForm)
-
-// Tells the renderer to find a focused element, and if it is a password field
-// eligible for generation then to trigger generation by responding to the
-// browser with the message |AutofillHostMsg_ShowPasswordGenerationPopup|.
-IPC_MESSAGE_ROUTED0(AutofillMsg_UserTriggeredGeneratePassword)
-
-// Tells the renderer that this password form is not blacklisted.  A form can
-// be blacklisted if a user chooses "never save passwords for this site".
-IPC_MESSAGE_ROUTED1(AutofillMsg_FormNotBlacklisted,
-                    autofill::PasswordForm /* form checked */)
-
-// Sent when Autofill manager gets the query response from the Autofill server
-// and there are fields classified for password generation in the response.
-IPC_MESSAGE_ROUTED1(
-    AutofillMsg_FoundFormsEligibleForGeneration,
-    std::vector<autofill::PasswordFormGenerationData> /* forms */)
-
-// Sent when Autofill manager gets the query response from the Autofill server
-// which contains information about username and password fields for some forms.
-// |predictions| maps forms to their username fields.
-IPC_MESSAGE_ROUTED1(AutofillMsg_AutofillUsernameAndPasswordDataReceived,
-                    FormsPredictionsMap /* predictions */)
-
-// Autofill messages sent from the renderer to the browser.
-
-// TODO(creis): check in the browser that the renderer actually has permission
-// for the URL to avoid compromised renderers talking to the browser.
-
-// Notification that password forms have been seen that are candidates for
-// filling/submitting by the password manager.
-IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormsParsed,
-                    std::vector<autofill::PasswordForm> /* forms */)
-
-// Notification that initial layout has occurred and the following password
-// forms are visible on the page (e.g. not set to display:none.), and whether
-// all frames in the page have been rendered.
-IPC_MESSAGE_ROUTED2(AutofillHostMsg_PasswordFormsRendered,
-                    std::vector<autofill::PasswordForm> /* forms */,
-                    bool /* did_stop_loading */)
-
-// A ping to the browser that PasswordAutofillAgent was constructed. As a
-// consequence, the browser sends AutofillMsg_SetLoggingState with the current
-// state of the logging activity.
-IPC_MESSAGE_ROUTED0(AutofillHostMsg_PasswordAutofillAgentConstructed)
-
-// Notification that this password form was submitted by the user.
-IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormSubmitted,
-                    autofill::PasswordForm /* form */)
-
-// Notification that in-page navigation happened and at this moment we have
-// filled password form. We use this as a signal for successful login.
-IPC_MESSAGE_ROUTED1(AutofillHostMsg_InPageNavigation,
-                    autofill::PasswordForm /* form */)
-
-// Sends |log| to browser for displaying to the user. Only strings passed as an
-// argument to methods overriding SavePasswordProgressLogger::SendLog may become
-// |log|, because those are guaranteed to be sanitized. Never pass a free-form
-// string as |log|.
-IPC_MESSAGE_ROUTED1(AutofillHostMsg_RecordSavePasswordProgress,
-                    std::string /* log */)
-
-// Queries the browser for Autofill suggestions for a form input field.
-IPC_MESSAGE_ROUTED4(AutofillHostMsg_QueryFormFieldAutofill,
-                    int /* id of this message */,
-                    autofill::FormData /* the form */,
-                    autofill::FormFieldData /* the form field */,
-                    gfx::RectF /* input field bounds, window-relative */)
-
 // Instructs the browser that generation is available for this particular form.
 // This is used for UMA stats.
 IPC_MESSAGE_ROUTED1(AutofillHostMsg_GenerationAvailableForForm,
                     autofill::PasswordForm)
 
 // Instructs the browser to show the password generation popup at the
 // specified location. This location should be specified in the renderers
 // coordinate system. Form is the form associated with the password field.
 IPC_MESSAGE_ROUTED5(AutofillHostMsg_ShowPasswordGenerationPopup,
                     gfx::RectF /* source location */,
                     int /* max length of the password */,
                     base::string16, /* password field */
                     bool,           /* is manually triggered */
                     autofill::PasswordForm)
 
 // Instructs the browser to show the popup for editing a generated password.
 // The location should be specified in the renderers coordinate system. Form
 // is the form associated with the password field.
 IPC_MESSAGE_ROUTED2(AutofillHostMsg_ShowPasswordEditingPopup,
                     gfx::RectF /* source location */,
                     autofill::PasswordForm)
 
 // Instructs the browser to hide any password generation popups.
 IPC_MESSAGE_ROUTED0(AutofillHostMsg_HidePasswordGenerationPopup)
-
-// Instructs the browser to presave the form with generated password.
-IPC_MESSAGE_ROUTED1(AutofillHostMsg_PresaveGeneratedPassword,
-                    autofill::PasswordForm)
-
-// Instructs the browser that form no longer contains a generated password and
-// the presaved form should be removed.
-IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordNoLongerGenerated,
-                    autofill::PasswordForm)
-
-// Sends the outcome of HTML parsing based form classifier that detects the
-// forms where password generation should be available.
-IPC_MESSAGE_ROUTED2(AutofillHostMsg_SaveGenerationFieldDetectedByClassifier,
-                    autofill::PasswordForm,
-                    base::string16 /* generation field */)
-
-// Instruct the browser to show a popup with suggestions filled from data
-// associated with |key|. The popup will use |text_direction| for displaying
-// text.
-IPC_MESSAGE_ROUTED5(
-    AutofillHostMsg_ShowPasswordSuggestions,
-    int /* key */,
-    base::i18n::TextDirection /* text_direction */,
-    base::string16 /* username typed by user */,
-    int /* options bitmask of autofill::ShowPasswordSuggestionsOptions */,
-    gfx::RectF /* input field bounds, window-relative */)
-
-// Inform the browser which password form is currently focused, as a response
-// to the |AutofillMsg_FindFocusedPasswordForm| request. If no password form
-// is focused, the response will contain an empty |autofill::PasswordForm|.
-IPC_MESSAGE_ROUTED1(AutofillHostMsg_FocusedPasswordFormFound,
-                    autofill::PasswordForm)