[Autofill] Migrate ContentPasswordManagerDriver<-->Password{Autofill,Generation}Agent IPCs to mojo.

chrome/renderer/autofill/password_generation_agent_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string.h>
 
 #include <memory>
 
 #include "base/macros.h"
+#include "base/run_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/histogram_tester.h"
 #include "chrome/renderer/autofill/password_generation_test_utils.h"
 #include "chrome/test/base/chrome_render_view_test.h"
 #include "components/autofill/content/common/autofill_messages.h"
 #include "components/autofill/content/renderer/autofill_agent.h"
 #include "components/autofill/content/renderer/test_password_generation_agent.h"
 #include "components/autofill/core/common/form_data.h"
 #include "components/autofill/core/common/password_generation_util.h"
+#include "content/public/renderer/render_frame.h"
+#include "content/public/renderer/render_view.h"
+#include "mojo/public/cpp/bindings/binding_set.h"
+#include "services/shell/public/cpp/interface_provider.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/WebKit/public/platform/WebString.h"
 #include "third_party/WebKit/public/web/WebDocument.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 #include "third_party/WebKit/public/web/WebWidget.h"
 #include "ui/events/keycodes/keyboard_codes.h"
 
 using blink::WebDocument;
 using blink::WebElement;
 using blink::WebInputElement;
 using blink::WebNode;
 using blink::WebString;
 
+namespace {
+
+class FakeContentPasswordManagerDriver

[vabr (Chromium), 2016/08/09 17:36:17]

Would it make sense to separate the definition of the fake class into its own
header, and #include it in the test instead of repeating the code?

[leonhsl(Using Gerrit), 2016/08/10 13:22:02]

Yeah agree. Put FakeContentPasswordManagerDriver into new files
fake_content_password_manager_driver.h and
fake_content_password_manager_driver.cc.
Done and thanks.

+    : public autofill::mojom::PasswordManagerDriver {
+ public:
+  FakeContentPasswordManagerDriver() {}
+
+  ~FakeContentPasswordManagerDriver() override {}
+
+  void BindRequest(autofill::mojom::PasswordManagerDriverRequest request) {
+    bindings_.AddBinding(this, std::move(request));
+  }
+
+  bool called_save_generation_field() const {
+    return called_save_generation_field_;
+  }
+
+  const base::Optional<base::string16>& save_generation_field() const {
+    return save_generation_field_;
+  }
+
+  void reset_save_generation_field() {
+    called_save_generation_field_ = false;
+    save_generation_field_ = base::nullopt;
+  }
+
+  bool called_password_no_longer_generated() const {
+    return called_password_no_longer_generated_;
+  }
+
+  void reset_called_password_no_longer_generated() {
+    called_password_no_longer_generated_ = false;
+  }
+
+  bool called_presave_generated_password() const {
+    return called_presave_generated_password_;
+  }
+
+  void reset_called_presave_generated_password() {
+    called_presave_generated_password_ = false;
+  }
+
+ private:
+  // mojom::PasswordManagerDriver:
+  void PasswordFormsParsed(
+      const std::vector<autofill::PasswordForm>& forms) override {}
+
+  void PasswordFormsRendered(
+      const std::vector<autofill::PasswordForm>& visible_forms,
+      bool did_stop_loading) override {}
+
+  void PasswordFormSubmitted(
+      const autofill::PasswordForm& password_form) override {}
+
+  void InPageNavigation(const autofill::PasswordForm& password_form) override {}
+
+  void PresaveGeneratedPassword(
+      const autofill::PasswordForm& password_form) override {
+    called_presave_generated_password_ = true;
+  }
+
+  void PasswordNoLongerGenerated(
+      const autofill::PasswordForm& password_form) override {
+    called_password_no_longer_generated_ = true;
+  }
+
+  void ShowPasswordSuggestions(int key,
+                               base::i18n::TextDirection text_direction,
+                               const base::string16& typed_username,
+                               int options,
+                               const gfx::RectF& bounds) override {}
+
+  void PasswordAutofillAgentConstructed() override {}
+
+  void RecordSavePasswordProgress(const std::string& log) override {}
+
+  void SaveGenerationFieldDetectedByClassifier(
+      const autofill::PasswordForm& password_form,
+      const base::string16& generation_field) override {
+    called_save_generation_field_ = true;
+    save_generation_field_ = generation_field;
+  }
+
+  // Records whether SaveGenerationFieldDetectedByClassifier() gets called.
+  bool called_save_generation_field_ = false;
+  // Records data received via SaveGenerationFieldDetectedByClassifier() call.
+  base::Optional<base::string16> save_generation_field_;
+  // Records whether PasswordNoLongerGenerated() gets called.
+  bool called_password_no_longer_generated_ = false;
+  // Records whether PresaveGeneratedPassword() gets called.
+  bool called_presave_generated_password_ = false;
+
+  mojo::BindingSet<autofill::mojom::PasswordManagerDriver> bindings_;
+};
+
+}  // namespace
+
 namespace autofill {
 
 class PasswordGenerationAgentTest : public ChromeRenderViewTest {
  public:
   PasswordGenerationAgentTest() {}
 
+  void RegisterMainFrameRemoteInterfaces() override {
+    // We only use the fake driver for main frame
+    // because our test cases only involve the main frame.
+    shell::InterfaceProvider* remote_interfaces =
+        view_->GetMainRenderFrame()->GetRemoteInterfaces();
+    shell::InterfaceProvider::TestApi test_api(remote_interfaces);
+    test_api.SetBinderForName(
+        mojom::PasswordManagerDriver::Name_,
+        base::Bind(&PasswordGenerationAgentTest::BindPasswordManagerDriver,
+                   base::Unretained(this)));
+  }
+
   void TearDown() override {
     LoadHTML("");
     ChromeRenderViewTest::TearDown();
   }
 
   void LoadHTMLWithUserGesture(const char* html) {
     LoadHTML(html);
 
     // Enable show-ime event when element is focused by indicating that a user
     // gesture has been processed since load.
@@ skipping 18 matching lines @@
             AutofillHostMsg_ShowPasswordGenerationPopup::ID);
     if (available)
       ASSERT_TRUE(message);
     else
       ASSERT_FALSE(message);
 
     render_thread_->sink().ClearMessages();
   }
 
   void AllowToRunFormClassifier() {
-    AutofillMsg_AllowToRunFormClassifier msg(0);
-    static_cast<IPC::Listener*>(password_generation_)->OnMessageReceived(msg);
+    password_generation_->AllowToRunFormClassifier();
   }
 
   void ExpectFormClassifierVoteReceived(
       bool received,
       const base::string16& expected_generation_element) {
-    const IPC::Message* message =
-        render_thread_->sink().GetFirstMessageMatching(
-            AutofillHostMsg_SaveGenerationFieldDetectedByClassifier::ID);
+    base::RunLoop().RunUntilIdle();
     if (received) {
-      ASSERT_TRUE(message);
-      std::tuple<autofill::PasswordForm, base::string16> actual_parameters;
-      AutofillHostMsg_SaveGenerationFieldDetectedByClassifier::Read(
-          message, &actual_parameters);
-      EXPECT_EQ(expected_generation_element, std::get<1>(actual_parameters));
+      ASSERT_TRUE(fake_driver_.called_save_generation_field());
+      EXPECT_EQ(expected_generation_element,
+                fake_driver_.save_generation_field());
     } else {
-      ASSERT_FALSE(message);
+      ASSERT_FALSE(fake_driver_.called_save_generation_field());
     }
 
-    render_thread_->sink().ClearMessages();
+    fake_driver_.reset_save_generation_field();
   }
 
   void ShowGenerationPopUpManually(const char* element_id) {
     FocusField(element_id);
-    AutofillMsg_UserTriggeredGeneratePassword msg(0);
-    static_cast<IPC::Listener*>(password_generation_)->OnMessageReceived(msg);
+    password_generation_->UserTriggeredGeneratePassword();
   }
 
+  void BindPasswordManagerDriver(mojo::ScopedMessagePipeHandle handle) {
+    fake_driver_.BindRequest(
+        mojo::MakeRequest<mojom::PasswordManagerDriver>(std::move(handle)));
+  }
+
+  FakeContentPasswordManagerDriver fake_driver_;
+
  private:
   DISALLOW_COPY_AND_ASSIGN(PasswordGenerationAgentTest);
 };
 
 const char kSigninFormHTML[] =
     "<FORM name = 'blah' action = 'http://www.random.com/'> "
     "  <INPUT type = 'text' id = 'username'/> "
     "  <INPUT type = 'password' id = 'password'/> "
     "  <INPUT type = 'button' id = 'dummy'/> "
     "  <INPUT type = 'submit' value = 'LOGIN' />"
@@ skipping 166 matching lines @@
   WebInputElement first_password_element = element.to<WebInputElement>();
   element = document.getElementById(WebString::fromUTF8("second_password"));
   ASSERT_FALSE(element.isNull());
   WebInputElement second_password_element = element.to<WebInputElement>();
 
   // Both password fields should be empty.
   EXPECT_TRUE(first_password_element.value().isNull());
   EXPECT_TRUE(second_password_element.value().isNull());
 
   base::string16 password = base::ASCIIToUTF16("random_password");
-  AutofillMsg_GeneratedPasswordAccepted msg(0, password);
-  static_cast<IPC::Listener*>(password_generation_)->OnMessageReceived(msg);
+  password_generation_->GeneratedPasswordAccepted(password);
 
   // Password fields are filled out and set as being autofilled.
   EXPECT_EQ(password, first_password_element.value());
   EXPECT_EQ(password, second_password_element.value());
   EXPECT_TRUE(first_password_element.isAutofilled());
   EXPECT_TRUE(second_password_element.isAutofilled());
 
   // Make sure onchange events are called.
   int first_onchange_called = -1;
   int second_onchange_called = -1;
@@ skipping 25 matching lines @@
   WebDocument document = GetMainFrame()->document();
   WebElement element =
       document.getElementById(WebString::fromUTF8("first_password"));
   ASSERT_FALSE(element.isNull());
   WebInputElement first_password_element = element.to<WebInputElement>();
   element = document.getElementById(WebString::fromUTF8("second_password"));
   ASSERT_FALSE(element.isNull());
   WebInputElement second_password_element = element.to<WebInputElement>();
 
   base::string16 password = base::ASCIIToUTF16("random_password");
-  AutofillMsg_GeneratedPasswordAccepted msg(0, password);
-  static_cast<IPC::Listener*>(password_generation_)->OnMessageReceived(msg);
+  password_generation_->GeneratedPasswordAccepted(password);
 
   // Passwords start out the same.
   EXPECT_EQ(password, first_password_element.value());
   EXPECT_EQ(password, second_password_element.value());
 
   // After editing the first field they are still the same.
   std::string edited_password_ascii = "edited_password";
   SimulateUserInputChangeForElement(&first_password_element,
                                     edited_password_ascii);
   base::string16 edited_password = base::ASCIIToUTF16(edited_password_ascii);
   EXPECT_EQ(edited_password, first_password_element.value());
   EXPECT_EQ(edited_password, second_password_element.value());
 
   // Clear any uninteresting sent messages.
   render_thread_->sink().ClearMessages();
+  fake_driver_.reset_called_password_no_longer_generated();
 
   // Verify that password mirroring works correctly even when the password
   // is deleted.
   SimulateUserInputChangeForElement(&first_password_element, std::string());
   EXPECT_EQ(base::string16(), first_password_element.value());
   EXPECT_EQ(base::string16(), second_password_element.value());
 
   // Should have notified the browser that the password is no longer generated
   // and trigger generation again.
-  EXPECT_TRUE(render_thread_->sink().GetFirstMessageMatching(
-      AutofillHostMsg_PasswordNoLongerGenerated::ID));
+  base::RunLoop().RunUntilIdle();
+  EXPECT_TRUE(fake_driver_.called_password_no_longer_generated());
   EXPECT_TRUE(render_thread_->sink().GetFirstMessageMatching(
       AutofillHostMsg_ShowPasswordGenerationPopup::ID));
 }
 
 TEST_F(PasswordGenerationAgentTest, BlacklistedTest) {
   // Did not receive not blacklisted message. Don't show password generation
   // icon.
   LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   SetAccountCreationFormsDetectedMessage(password_generation_,
                                          GetMainFrame()->document(), 0, 1);
@@ skipping 267 matching lines @@
                     {kPasswordChangeFormHTML, "newpassword"}};
   for (auto& test_case : kTestCases) {
     SCOPED_TRACE(testing::Message("form: ") << test_case.form);
     LoadHTMLWithUserGesture(test_case.form);
     // To be able to work with input elements outside <form>'s, use manual
     // generation.
     ShowGenerationPopUpManually(test_case.generation_element);
     ExpectGenerationAvailable(test_case.generation_element, true);
 
     base::string16 password = base::ASCIIToUTF16("random_password");
-    AutofillMsg_GeneratedPasswordAccepted msg(0, password);
-    static_cast<IPC::Listener*>(password_generation_)->OnMessageReceived(msg);
-    EXPECT_TRUE(render_thread_->sink().GetFirstMessageMatching(
-        AutofillHostMsg_PresaveGeneratedPassword::ID));
-    render_thread_->sink().ClearMessages();
+    password_generation_->GeneratedPasswordAccepted(password);
+    base::RunLoop().RunUntilIdle();
+    EXPECT_TRUE(fake_driver_.called_presave_generated_password());
+    fake_driver_.reset_called_presave_generated_password();
 
     FocusField(test_case.generation_element);
     SimulateUserTypingASCIICharacter('a', true);
-    EXPECT_TRUE(render_thread_->sink().GetFirstMessageMatching(
-        AutofillHostMsg_PresaveGeneratedPassword::ID));
-    render_thread_->sink().ClearMessages();
+    base::RunLoop().RunUntilIdle();
+    EXPECT_TRUE(fake_driver_.called_presave_generated_password());
+    fake_driver_.reset_called_presave_generated_password();
 
     for (size_t i = 0; i < password.length(); ++i)
       SimulateUserTypingASCIICharacter(ui::VKEY_BACK, false);
     SimulateUserTypingASCIICharacter(ui::VKEY_BACK, true);
-    EXPECT_TRUE(render_thread_->sink().GetFirstMessageMatching(
-        AutofillHostMsg_PasswordNoLongerGenerated::ID));
-    render_thread_->sink().ClearMessages();
+    base::RunLoop().RunUntilIdle();
+    EXPECT_TRUE(fake_driver_.called_password_no_longer_generated());
+    fake_driver_.reset_called_password_no_longer_generated();
   }
 }
 
 TEST_F(PasswordGenerationAgentTest, FormClassifierVotesSignupForm) {
   AllowToRunFormClassifier();
   LoadHTMLWithUserGesture(kAccountCreationFormHTML);
   ExpectFormClassifierVoteReceived(true /* vote is expected */,
                                    base::ASCIIToUTF16("first_password"));
 }
 
 TEST_F(PasswordGenerationAgentTest, FormClassifierVotesSigninForm) {
   AllowToRunFormClassifier();
   LoadHTMLWithUserGesture(kSigninFormHTML);
   ExpectFormClassifierVoteReceived(true /* vote is expected */,
                                    base::string16());
 }
 
 TEST_F(PasswordGenerationAgentTest, FormClassifierDisabled) {
   LoadHTMLWithUserGesture(kSigninFormHTML);
   ExpectFormClassifierVoteReceived(false /* vote is not expected */,
                                    base::string16());
 }
 
 }  // namespace autofill