Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2216453002: [turbofan] Use CheckMaps for the COW check on elements. (Closed)

Created:
4 years, 4 months ago by Benedikt Meurer
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use CheckMaps for the COW check on elements. Use a single CheckMaps node instead of the sequence of LoadField, ReferenceEqual and CheckIf. This also makes it easier to eliminate the COW check if there are multiple of them in a row. R=yangguo@chromium.org Committed: https://crrev.com/887583a15a37bc0d012affb54270bbe8b91185c8 Cr-Commit-Position: refs/heads/master@{#38321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 chunk +3 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Benedikt Meurer
4 years, 4 months ago (2016-08-04 05:47:31 UTC) #1
Yang
lgtm
4 years, 4 months ago (2016-08-04 05:50:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2216453002/1
4 years, 4 months ago (2016-08-04 05:51:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 06:07:11 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 06:07:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/887583a15a37bc0d012affb54270bbe8b91185c8
Cr-Commit-Position: refs/heads/master@{#38321}

Powered by Google App Engine
This is Rietveld 408576698